-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/lsminterval] Optimize pebble usage #270
base: main
Are you sure you want to change the base?
Conversation
89fe644
to
31d1b35
Compare
Bench stats with
|
// large batches will need to be reallocated. Note that large batch | ||
// classification uses the memtable size that a batch will occupy | ||
// rather than the length of data slice backing the batch. | ||
pebbleMemTableSize = 64 << 20 // 64MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[For reviewers] I have gone a bit high here, this would mean we would require 64*2=128MB of memory at-least (due to max number of memtables as configured via pebbleMemTableStopWritesThreshold
) for memtable. This should be good for most of our use cases - also, we could expose these configs in the component configuration for tweaking in future but I haven't done that in this PR.
Detailed description on the changes available in godocs