[receiver/elasticapmintake]Add service.node.name and other missing fields #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girodav
force-pushed
the
add-missing-fields
branch
from
1b40617 to
b6ace73
Compare
gregkalapos
reviewed
Jul 30, 2025
Contributor
gregkalapos
left a comment
gregkalapos
left a comment
There was a problem hiding this comment.
One question to AttributeDeploymentEnvironment below.
The rest looks ok to me. 👍
receiver/elasticapmintakereceiver/internal/mappers/intakeV2ToSemConv.go
Outdated
Show resolved
Hide resolved
gregkalapos
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service.node.name(APM) ->service.instance.id(SemConv)service.environmentto matchelasticsearchexporter