Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elasticsearch.privileges.cluster support #226

Merged
merged 6 commits into from
Oct 15, 2021

Conversation

stuartnelson3
Copy link
Contributor

@stuartnelson3 stuartnelson3 commented Oct 13, 2021

What does this PR do?

add an optional elasticsearch.cluster property to the package manifest to define cluster privileges to be assigned to an api key

Why is it important?

APM server needs additional cluster privileges to access / on its elasticsearch output

Checklist

Related issues

proposed in #224

@stuartnelson3
Copy link
Contributor Author

@mtojek I interpreted this sentence:

Maybe it would be good enough to keep it in the package manifest?

to mean that I should make my changes in the top-level manifest.yml. If this is wrong let me know!

@elasticmachine
Copy link

elasticmachine commented Oct 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T12:11:34.174+0000

  • Duration: 2 min 12 sec

  • Commit: 57ca8b8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ruflin ruflin requested a review from joshdover October 13, 2021 10:39
@ruflin
Copy link
Member

ruflin commented Oct 13, 2021

@joshdover Requested your review on this from a Fleet perspective to make sure it will work as expected in Kibana. Ideally we would have the Kibana PR already open in parallel.

@joshdover
Copy link
Contributor

Thanks. I'm going to delegate this to @nchaulet since he's working on elastic/kibana#114686 already.

@stuartnelson3
Copy link
Contributor Author

Based on the work being done in elastic/kibana#114945, are we ok with the nesting? @joshdover @nchaulet

versions/1/changelog.yml Outdated Show resolved Hide resolved
@stuartnelson3 stuartnelson3 changed the title add elasticsearch.cluster support add elasticsearch.privileges.cluster support Oct 14, 2021
@@ -106,6 +106,21 @@ spec:
- "1.0.0-SNAPSHOT"
- "1.0.0-dev.1"
properties:
elasticsearch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that these properties are more or less sorted in prioritized order, which means that "elasticsearch" as extension should be at the bottom.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartnelson3 this one is still not addressed

versions/1/manifest.spec.yml Show resolved Hide resolved
@mtojek mtojek requested a review from jsoriano October 14, 2021 09:50
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have a working PR with that for Kibana and the package registry and looks like it's working 👍

@mtojek
Copy link
Contributor

mtojek commented Oct 15, 2021

This PR hasn't received all approvals and got merged. There is also an unaddressed comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants