Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elasticsearch.privileges.cluster support #226

Merged
merged 6 commits into from
Oct 15, 2021
Merged

add elasticsearch.privileges.cluster support #226

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6cba73
add elasticsearch.cluster support
stuartnelson3 Oct 13, 2021
1976b5b
update changelog
stuartnelson3 Oct 13, 2021
1d07548
fix description
stuartnelson3 Oct 13, 2021
d1b0642
nest cluster under privileges
stuartnelson3 Oct 13, 2021
08863b7
update changelog
stuartnelson3 Oct 14, 2021
57ca8b8
link to documentation and clarify /main
stuartnelson3 Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/packages/good/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ icons:
title: system
size: 1000x1000
type: image/svg+xml
elasticsearch.privileges.cluster: [monitor/main]
3 changes: 3 additions & 0 deletions versions/1/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
- description: Add tag support for elastic export
type: bugfix
link: https://github.com/elastic/package-spec/pull/223
- description: Add "elasticsearch.cluster" to package manifest
stuartnelson3 marked this conversation as resolved.
Show resolved Hide resolved
type: enhancement
link: https://github.com/elastic/package-spec/pull/226
- version: 1.1
changes:
- description: Prepare for 1.0.1
Expand Down
15 changes: 15 additions & 0 deletions versions/1/manifest.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,21 @@ spec:
- "1.0.0-SNAPSHOT"
- "1.0.0-dev.1"
properties:
elasticsearch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that these properties are more or less sorted in prioritized order, which means that "elasticsearch" as extension should be at the bottom.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartnelson3 this one is still not addressed

description: Elasticsearch requirements
type: object
additionalProperties: false
properties:
privileges:
description: Elasticsearch privilege requirements
type: object
additionalProperties: false
properties:
cluster:
description: Elasticsearch cluster privilege requirements
mtojek marked this conversation as resolved.
Show resolved Hide resolved
type: array
items:
type: string
format_version:
description: The version of the package specification format used by this package.
$ref: "#/definitions/version"
Expand Down