Prepare for support of multiple, independent package types #323
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| @@ -9,7 +9,7 @@ import ( | |||
| "io/fs" | |||
| ) | |||
|
|
|||
| //go:embed versions/1 versions/1/_dev versions/1/data_stream/_dev | |||
| //go:embed versions/1 versions/1/integration/_dev versions/1/integration/data_stream/_dev | |||
There was a problem hiding this comment.
@jsoriano Does Go ignore _underscore-dirs by design? I must have missed something here.
There was a problem hiding this comment.
Yes, there are certain parts of Go that ignore dirs prefixed with underscores and the testdata directory. For example I think that go get doesn't get these files by default, and go test ./... probably doesn't look for tests there.
I think that files referenced by embed are also seen by go get and some other commands that would ignore them otherwise.
There was a problem hiding this comment.
Ok, I guess it's a workaround then. The PR is ready for a review round.
Meta-issue: #319
This PR modifies the package-spec logic to support multiple package types under
versions/1/. I think that it's more like a technical PR to open implementation for extending with more package types.Fun fact: it's really concerning that we haven't required
type: integrationto be present.