Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Bulk edit rule actions #2441

Closed
joepeeples opened this issue Sep 6, 2022 · 1 comment · Fixed by #2567
Closed

[DOCS] Bulk edit rule actions #2441

joepeeples opened this issue Sep 6, 2022 · 1 comment · Fixed by #2567

Comments

@joepeeples
Copy link
Contributor

joepeeples commented Sep 6, 2022

Description

Per elastic/kibana#138900, users can bulk edit actions on multiple rules.

elastic/kibana#140626 also makes some additional changes to the flyout and functionality.

Images

NOTE: UI copy is still being edited; these are preliminary images.

New item in "Bulk actions" menu:
image

New flyout:
image

Notes

@banderror
Copy link
Contributor

elastic/kibana#140626 also makes some additional changes to the flyout and functionality.

I can expand on what we changed in this PR:

  • We removed the Perform no actions option from the Actions frequency dropdown.
    • This means users will no longer be able to mute existing rule actions (this is effectively done under the hood by the app when this frequency is applied) or (if the overwrite checkbox is checked) remove all existing actions from the affected rules.
    • Users will still be able to mute actions when editing rules individually.
  • Consequently, rules can no longer be muted by a bulk action under the hood. Previously, if the user selected Perform no actions we'd mute the affected rules. Now when we don't provide this option we don't need this logic in the bulk action endpoint anymore.
  • FYI muting is a feature of the Alerting Framework which is not yet supported in Security Solution but is available in Stack Management. This PoC is the first step toward adding support for muting in Security Solution.

@jpdjere jpdjere self-assigned this Sep 27, 2022
jpdjere added a commit that referenced this issue Sep 30, 2022
## Relates to:
#2441
#2453

## Changes

- Updated Bulk Update API request to include new possible payloads for:
    - Bulk Update Schedule
    - Bulk Update Rule Actions

## Images
![image](https://user-images.githubusercontent.com/5354282/192609873-9dc20d53-0beb-4489-9987-df611a735801.png)
mergify bot pushed a commit that referenced this issue Sep 30, 2022
## Relates to:
#2441
#2453

## Changes

- Updated Bulk Update API request to include new possible payloads for:
    - Bulk Update Schedule
    - Bulk Update Rule Actions

## Images
![image](https://user-images.githubusercontent.com/5354282/192609873-9dc20d53-0beb-4489-9987-df611a735801.png)

(cherry picked from commit c76fac6)
joepeeples pushed a commit that referenced this issue Sep 30, 2022
## Relates to:
#2441
#2453

## Changes

- Updated Bulk Update API request to include new possible payloads for:
    - Bulk Update Schedule
    - Bulk Update Rule Actions

## Images
![image](https://user-images.githubusercontent.com/5354282/192609873-9dc20d53-0beb-4489-9987-df611a735801.png)

(cherry picked from commit c76fac6)

Co-authored-by: Juan Pablo Djeredjian <jpdjeredjian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants