Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Bulk edit rules updates (rule schedules, actions) #2567

Merged
merged 8 commits into from
Oct 18, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Oct 12, 2022

@github-actions
Copy link

Documentation previews:

@joepeeples joepeeples marked this pull request as ready for review October 12, 2022 19:59
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One trivial suggestion for your consideration, otherwise LGTM

docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
joepeeples and others added 2 commits October 13, 2022 11:36
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joepeeples joepeeples mentioned this pull request Oct 13, 2022
28 tasks
@joepeeples joepeeples added the readyforQA PRs that are ready for QA review. label Oct 17, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

Hi Team,

We have validated above PR and the changes are good to go. Hence, marking it as 'QA Validated.

Thanks !

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Oct 18, 2022
@joepeeples joepeeples merged commit 659de03 into main Oct 18, 2022
mergify bot pushed a commit that referenced this pull request Oct 19, 2022
* Add rule actions option

* Add rule schedules option

* Add note on action frequency

* Lil edit

* Update docs/detections/rules-ui-manage.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Revise note

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 659de03)
@joepeeples joepeeples deleted the 2441-2453-rules-bulk-edit-actions-schedules branch October 19, 2022 00:00
joepeeples added a commit that referenced this pull request Oct 19, 2022
* Add rule actions option

* Add rule schedules option

* Add note on action frequency

* Lil edit

* Update docs/detections/rules-ui-manage.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Revise note

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 659de03)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Rules QA:Validated Issue has been Validated by QA Team Team: Detections/Response Detections and Response Team: Docs v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Bulk edit rule schedules [DOCS] Bulk edit rule actions
4 participants