Creates CSPM privileges standalone page #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
opauloh
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Nice work consolidating all privilege requirements into a single page! Some thoughts about the way the information is presented:
I feel that the current page layout answers the question “What does the read/write/manage privilege allow users to do?” but it could be more helpful to reframe the information so that it answers the question “For each specific action (e.g. enable or disable benchmark rules), what are the minimum privileges a user needs?” On the requirements pages for other features (e.g. Detections requirements or Cases requirements), we do that by using the tabular layout with “Action” as the first column. This focuses more on the different user actions and provides the minimum privileges for each of those actions. I think following the same convention and layout on this page would make the information easier to find and give users a more consistent docs experience.
| @@ -0,0 +1,61 @@ | |||
| [[cspm-required-permissions]] | |||
| = CSPM privilege requirements | |||
There was a problem hiding this comment.
Suggested change
| = CSPM privilege requirements | |
| = CSPM requirements |
Just for consistency with other requirements pages
There was a problem hiding this comment.
This page is focused only on privileges. Other requirements are listed in the getting started guides
Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
There was a problem hiding this comment.
LGTM! If you choose to revisit the content's format, 1+ to @natasha-moore-elastic's suggestion for presenting the information in a table format and with summarized action descriptions.
docs/serverless/cloud-native-security/cspm-permissions.asciidoc
Outdated
Show resolved
Hide resolved
docs/serverless/cloud-native-security/cspm-permissions.asciidoc
Outdated
Show resolved
Hide resolved
docs/serverless/cloud-native-security/cspm-permissions.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
natasha-moore-elastic
approved these changes
Dec 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Creates CSPM privileges standalone page * ports updates to serverless * Apply suggestions from code review Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 51b58c2) # Conflicts: # docs/serverless/cloud-native-security/cspm-get-started-azure.asciidoc # docs/serverless/cloud-native-security/cspm-get-started-gcp.asciidoc # docs/serverless/cloud-native-security/cspm-get-started.asciidoc # docs/serverless/index.asciidoc
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Creates CSPM privileges standalone page * ports updates to serverless * Apply suggestions from code review Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 51b58c2) # Conflicts: # docs/serverless/cloud-native-security/cspm-get-started-azure.asciidoc # docs/serverless/cloud-native-security/cspm-get-started-gcp.asciidoc # docs/serverless/cloud-native-security/cspm-get-started.asciidoc # docs/serverless/index.asciidoc
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Creates CSPM privileges standalone page * ports updates to serverless * Apply suggestions from code review Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 51b58c2) # Conflicts: # docs/serverless/cloud-native-security/cspm-get-started-azure.asciidoc # docs/serverless/cloud-native-security/cspm-get-started-gcp.asciidoc # docs/serverless/cloud-native-security/cspm-get-started.asciidoc # docs/serverless/index.asciidoc
This was referenced Dec 13, 2024
benironside
added a commit
that referenced
this pull request
Dec 13, 2024
* Creates CSPM privileges standalone page (#6269) * Creates CSPM privileges standalone page * ports updates to serverless * Apply suggestions from code review Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 51b58c2) # Conflicts: # docs/serverless/cloud-native-security/cspm-get-started-azure.asciidoc # docs/serverless/cloud-native-security/cspm-get-started-gcp.asciidoc # docs/serverless/cloud-native-security/cspm-get-started.asciidoc # docs/serverless/index.asciidoc * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benironside
added a commit
that referenced
this pull request
Dec 13, 2024
* Creates CSPM privileges standalone page (#6269) * Creates CSPM privileges standalone page * ports updates to serverless * Apply suggestions from code review Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 51b58c2) # Conflicts: # docs/serverless/cloud-native-security/cspm-get-started-azure.asciidoc # docs/serverless/cloud-native-security/cspm-get-started-gcp.asciidoc # docs/serverless/cloud-native-security/cspm-get-started.asciidoc # docs/serverless/index.asciidoc * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benironside
added a commit
that referenced
this pull request
Dec 13, 2024
* Creates CSPM privileges standalone page (#6269) * Creates CSPM privileges standalone page * ports updates to serverless * Apply suggestions from code review Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 51b58c2) # Conflicts: # docs/serverless/cloud-native-security/cspm-get-started-azure.asciidoc # docs/serverless/cloud-native-security/cspm-get-started-gcp.asciidoc # docs/serverless/cloud-native-security/cspm-get-started.asciidoc # docs/serverless/index.asciidoc * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6261 — Creates a standalone page that describes the privileges that grant different levels of access to CSPM features. Removes the lists of privileges from the requirements sections of each of the CSPM get started guides for AWS, GCP, and Azure, and replaces them with a link to the new page, which includes more details.
Preview: CSPM privilege requirements ESS, Serverless