-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run linter using PHP 8.1 as well (and fix any issues) #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Production (when switched to PHP 8.1) reports: [22-Sep-2022 15:33:25 Europe/Berlin] PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/home/macbre/elecena/git/app/vendor/elecena/nano/classes/Router.class.php on line 286 [22-Sep-2022 15:33:25 Europe/Berlin] PHP Deprecated: Return type of DatabaseResult::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /usr/home/macbre/elecena/git/app/vendor/elecena/nano/classes/DatabaseResult.class.php on line 101
Yay!
|
macbre
added a commit
that referenced
this pull request
Sep 22, 2022
PHP Deprecated: Return type of DatabaseResult::... should either be compatible with ... Resolves #153
macbre
changed the title
Run linter using PHP 8.1 as well
Run linter using PHP 8.1 as well (and fix any issues)
Sep 22, 2022
macbre
added a commit
that referenced
this pull request
Sep 22, 2022
PHP Deprecated: Return type of DatabaseResult::... should either be compatible with ... Resolves #153
macbre
force-pushed
the
php81/linter
branch
from
September 22, 2022 13:55
2537826
to
be97149
Compare
PHP Deprecated: Return type of DatabaseResult::... should either be compatible with ... Resolves #153
macbre
force-pushed
the
php81/linter
branch
from
September 22, 2022 13:57
be97149
to
4ec0b71
Compare
Fixes: PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/home/macbre/elecena/git/app/vendor/elecena/nano/classes/Router.class.php on line 286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production (when switched to PHP 8.1) reports: