Skip to content

Commit

Permalink
fix(win): Revert "fix(win): use appInfo description as primary entry …
Browse files Browse the repository at this point in the history
…for FileDescription" (#8601)

Reverts #8125
The PR caused a regression where task manager shows the app description
instead of the app name for the running process

Fixes: #8599
  • Loading branch information
mmaietta authored Oct 15, 2024
1 parent f941f18 commit 215fc36
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/stupid-buses-compete.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

Revert "fix(win): use appInfo description as primary entry for FileDescription" to resolve https://github.com/electron-userland/electron-builder/issues/8599
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/winPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {
file,
"--set-version-string",
"FileDescription",
appInfo.description || appInfo.productName,
appInfo.productName,
"--set-version-string",
"ProductName",
appInfo.productName,
Expand Down

0 comments on commit 215fc36

Please sign in to comment.