Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win): use appInfo description as primary entry for FileDescription #8125

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mmaietta
Copy link
Collaborator

Fixes: #7897 7897

Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 09f20df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 09f20df
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65efa30b8a5dac0008a4b42c
😎 Deploy Preview https://deploy-preview-8125--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit c6c9d59 into master Mar 12, 2024
15 checks passed
@mmaietta mmaietta deleted the windows-file-descriptor branch March 12, 2024 01:00
mmaietta added a commit that referenced this pull request Oct 15, 2024
…for FileDescription" (#8601)

Reverts #8125
The PR caused a regression where task manager shows the app description
instead of the app name for the running process

Fixes: #8599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building on Windows does not write the description from package.json into the FileDescription field of the exe
1 participant