-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nsis): Windows on ARM support #4228
Conversation
This change causes NSIS installers built on macOS to crash on Windows:
|
@lutzroeder I've gotta be honest, he merged my PR on this project before I properly validated and debugged the updated scripts. I wasn't able to validate the scripts without electron-builder-binaries being updated, and I made a PR there too. Both PRs were approved essentially at the same time, so by the time I had the ability to validate it, my PR was already merged. I ran the built in tests after making my changes, and they passed, meaning the scripts are valid, but because of the reason above, I haven't been able to actually fully vet it before merging. There was a reason why not all the checkboxes were checked, lol. Anywayyyyy... Are there any error messages, or logs, or anything that could help us diagnose the issue? |
Crash log running the installer on Windows is included in #4374. Should the change be reverted while this is getting tested and investigated as it will produce invalid installers that get pushed out to users? |
Sorry I didn't respond. My life has been all over the place lately. Yes, that's fine, and I noticed you already did it. At least until we can figure out what change broke it on macOS. |
Is this change ready? The PR that tried to revert this is closed: #4416 but when I tried to add arm64 support to my app, the universal-arch NSIS doesn't seem to work correctly on my x64 system. It only installs the |
Checklist:
(External) Update NSIS in electron-userland/electron-builder-binaries to NSIS 3.0.4, or at least support Native CPU arch detection in x64.nsh (GetNativeMachineArchitecture and related, as shown in https://github.com/kichik/nsis/blob/master/Include/x64.nsh)
Done, pending merge electron-userland/electron-builder-binaries#27
Successfully validate updated NSIS scripts
Update test scripts to target electron 6.0.8 or later
Update test scripts to target win/arm64 on windows hosts