-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build on windows with 22.10.5 #5668
Comments
Happy to get this fixed asap. I'm not sure why Can you create a minimum repro repo for this? Such as with electron-quick-start? It'd help a lot in debugging further locally. |
Yah I'll spend some cycles on this in the morning. Much rather not be version locked. |
So I've been working at this all day and basically came down and recreated the environment locally after trying to recreate with the electron-quick-start, electron.net source and my local project that is failing. and nothing.... it works, it just simply works... I have no idea why its working. however notably the only real difference in the ouput between local and the build server is the downolading of the files. locally, using my same commands I get no downloads of 11.1.1, winCodeSign, nsis or nsis-resouces, but the build server IS doing thos downloads during the electron-builder call Powershell output locally, notice the lace of downloading calls.
So, I'm kind of stumped here. feels more and more like I've got some weird edge case I should be able to tinker around with to get working. any thoughts? |
Hi @danatcofo, I'm honestly sure why the downloads would fail for electron-builder on local but not on the build server. It does indeed seem like an edge case. Curious, if you change the electron version, would it still fail? Can you run with |
I have a same issue on Mac while using this with github actions, any idea on how to fix this? (electron 11.3) |
I have the same issue on macOS with electron 12.0.1 and electron-builder 22.10.5. I would be happy to give @mmaietta access to the repo, if that helps. |
Many thanks all for confirming the different electron + electron-builder versions, I appreciate it. |
FWIW my issue was fixed by upgrading from Node 13.8.0 to 15.12.0. |
I have same issue when packing on Stack trace when build failed is following.
|
The Linux version does not build with the current version 22.10.5. It could be related to electron-builder issue #5668 electron-userland/electron-builder#5668
Same thing happened for me, Travis CI, 22.10.5 |
Thankfully this was fixed for me after downgrading NodeJS from 16.0.0 to 15.14.0. |
On Mac arm64 this is happening too. |
I've encountered the same problem as well with NodeJS v16.0.0 on Windows 10. Downgrading to v15.14.0 resolved the issue |
Unfortunately, this is not a solution. |
Also having this issue on M1 mac mini and node 16. downgrading electron-builder to 22.10.4 fixes the issue. |
I'm having issues on node 16 on an Intel Mac. Rolling back to node 14 (since that's easy in brew) cleared it up. |
Same issue on Arch Linux using node 16 |
Same issue on mac OS node 16 |
I think the title should be change to reflect this, as it's tagged as Windows only |
Same issue on macOS node@16, it works when I downgrade to node@14. |
for all having this issue right now, downgrade your nodeJS to anything below 16.0 |
On macOS: if you're running Next press Then press Close this Terminal window and open a new Terminal and re-run your command. |
Same iussue here on Manjaro and NodeJs 16. |
Should be fixed in 22.11.4 |
Tested working on windows with node 16 |
Looks like this was fixed in 22.11.4 and a regression appeared in 22.11.5 that recreated the issue. |
It doesn't seem like there's any open issue tracking the new regression here... Should this be reopened, or should a new issue be filed? |
This sucks, electron-builder breaks all the time and node-abi is always out of date. |
@quinton-ashley Can you do better? Theses packages depends on A LOT of stuff and we are very lucky to have this team. Please be constructive on repos you don't own. |
Folks who want to be productive about this should probably re-test against 22.11.7 (the current version as of this message) and if the issue continues open a new issue for the bug. Include a reference to this issue and the fact that it appears to have been a regression in 22.11.5 to help the developers search for the breaking change. I haven't had the time to do that myself in part because 22.11.4 still works for my project. |
Same here on MacOS 10.15.2, Node 16. Downgrading to Node 15.14.0 works |
I ran the experiment I mentioned in my previous post and the build appears to work properly with 22.11.7 on Mac OS 10.15.7, Node 16.1, and an Intel processor. So if you're seeing problems you probably need to first update all the related tools and then if still having trouble provide more details (and given the developer's choice not to re-open this issue file a new one with the details needed to reproduce the problem). |
I have this issue when using node 16 but on current LTS as of this posting(v14) it works fine. |
Summary: `yarn build --mac` started failing with errors. This fixes it. Probable root cause: electron-userland/electron-builder#5668 Reviewed By: aigoncharov Differential Revision: D32101006 fbshipit-source-id: 50011f8be8079bd96c8f602002ccb500c3ad4794
CI seemed to be running into electron-userland/electron-builder#5668, likely due to the github CI images being updated to node 16. We can either pin the node version used or update electron-builder, and the latter seems the more future facing approach.
The Linux version does not build with the current version 22.10.5. It could be related to electron-builder issue #5668 electron-userland/electron-builder#5668
Same here on my angular + electron app , Node 16 , Downgraded to Node 15.14.0, now working fine . |
The Linux version does not build with the current version 22.10.5. It could be related to electron-builder issue #5668 electron-userland/electron-builder#5668
Version: 22.10.5
Electron Version: 11.1.1
Electron Type (current, beta, nightly): current
Target: windows
Building on an Azure DevOps build server. I have 2 builds and the only difference between a working and an non-working is the electron-builder version and that its a Windows target. The macos target builds fine.
working: electron-builder 22.9.1
not working: 22.10.5
here are the outputs. I'll truncate the stacktrace as it doesn't really have any value being repetative.
WORKING
NOT WORKING
The text was updated successfully, but these errors were encountered: