Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on windows with 22.10.5 #5668

Closed
danatcofo opened this issue Mar 2, 2021 · 37 comments
Closed

Unable to build on windows with 22.10.5 #5668

danatcofo opened this issue Mar 2, 2021 · 37 comments
Assignees

Comments

@danatcofo
Copy link

  • Version: 22.10.5

  • Electron Version: 11.1.1

  • Electron Type (current, beta, nightly): current

  • Target: windows

Building on an Azure DevOps build server. I have 2 builds and the only difference between a working and an non-working is the electron-builder version and that its a Windows target. The macos target builds fine.

working: electron-builder 22.9.1
not working: 22.10.5

here are the outputs. I'll truncate the stacktrace as it doesn't really have any value being repetative.

WORKING

D:\a\1\s\src\Prefix-App\obj\desktop\-encodedCommand>npx electron-builder --config=./bin/electron-builder.json --win --x64 -c.electronVersion=11.1.1 
  • electron-builder  version=22.9.1 os=10.0.17763
  • artifacts will be published if draft release exists  reason=CI detected
  • loaded configuration  file=D:\a\1\s\src\Prefix-App\obj\desktop\-encodedCommand\bin\electron-builder.json
  • description is missed in the package.json  appPackageFile=D:\a\1\s\src\Prefix-App\obj\desktop\-encodedCommand\package.json
  • packaging       platform=win32 arch=x64 electron=11.1.1 appOutDir=D:\a\1\s\dist\win-unpacked
  • downloading     url=https://github.com/electron/electron/releases/download/v11.1.1/electron-v11.1.1-win32-x64.zip size=78 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v11.1.1/electron-v11.1.1-win32-x64.zip duration=3.946s
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/winCodeSign-2.6.0/winCodeSign-2.6.0.7z size=5.6 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/winCodeSign-2.6.0/winCodeSign-2.6.0.7z duration=567ms
  • building        target=nsis file=D:\a\1\s\dist\stackify-prefix.exe archs=x64 oneClick=true perMachine=false
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/nsis-3.0.4.1/nsis-3.0.4.1.7z size=1.3 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/nsis-3.0.4.1/nsis-3.0.4.1.7z duration=352ms
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/nsis-resources-3.4.1/nsis-resources-3.4.1.7z size=731 kB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/nsis-resources-3.4.1/nsis-resources-3.4.1.7z duration=405ms
  • building block map  blockMapFile=D:\a\1\s\dist\stackify-prefix.exe.blockmap
  ⨯ GitHub Personal Access Token is not set, neither programmatically, nor using env "GH_TOKEN"
D:\a\1\s\src\Prefix-App\obj\desktop\-encodedCommand>
... done

NOT WORKING

D:\a\1\s\src\Prefix-App\obj\desktop\-encodedCommand>npx electron-builder --config=./bin/electron-builder.json --win --x64 -c.electronVersion=11.1.1 
  • electron-builder  version=22.10.5 os=10.0.17763
  • artifacts will be published if draft release exists  reason=CI detected
  • loaded configuration  file=D:\a\1\s\src\Prefix-App\obj\desktop\-encodedCommand\bin\electron-builder.json
  • description is missed in the package.json  appPackageFile=D:\a\1\s\src\Prefix-App\obj\desktop\-encodedCommand\package.json
  • packaging       platform=win32 arch=x64 electron=11.1.1 appOutDir=D:\a\1\s\dist\win-unpacked
  • Unpacking electron zip  zipPath=undefined
  • downloading     url=https://github.com/electron/electron/releases/download/v11.1.1/electron-v11.1.1-win32-x64.zip size=78 MB parts=4
  • downloaded      url=https://github.com/electron/electron/releases/download/v11.1.1/electron-v11.1.1-win32-x64.zip duration=1.812s
  ⨯ editions-autoloader-none-broadened: Unable to determine a suitable edition, even after broadening.  stackTrace=
                                                                                                          Error: editions-autoloader-none-broadened: Unable to determine a suitable edition, even after broadening.
                                                                                                              at new Errlop (C:\npm\prefix\node_modules\electron-builder\node_modules\errlop\edition-es5\index.js:61:18)
                                                                                                              at Object.errtion (C:\npm\prefix\node_modules\electron-builder\node_modules\editions\edition-es5\util.js:23:14)
                                                                                                              at determineEdition (C:\npm\prefix\node_modules\electron-builder\node_modules\editions\edition-es5\index.js:317:21)
                                                                                                              at solicitEdition (C:\npm\prefix\node_modules\electron-builder\node_modules\editions\edition-es5\index.js:350:16)
                                                                                                              at Object.requirePackage (C:\npm\prefix\node_modules\electron-builder\node_modules\editions\edition-es5\index.js:364:9)
                                                                                                              at Object.<anonymous> (C:\npm\prefix\node_modules\electron-builder\node_modules\istextorbinary\index.cjs:4:38)
                                                                                                              at Module._compile (internal/modules/cjs/loader.js:1118:30)
                                                                                                              at Object.Module._extensions..js (internal/modules/cjs/loader.js:1138:10)
                                                                                                              at Module.load (internal/modules/cjs/loader.js:982:32)
                                                                                                              at Function.Module._load (internal/modules/cjs/loader.js:875:14)
                                                                                                              at Module.require (internal/modules/cjs/loader.js:1022:19)
                                                                                                              at require (internal/modules/cjs/helpers.js:72:18)
                                                                                                              at Object.<anonymous> (C:\npm\prefix\node_modules\electron-builder\node_modules\app-builder-lib\electron-osx-sign\util.js:135:22)
                                                                                                              at Module._compile (internal/modules/cjs/loader.js:1118:30)
                                                                                                              at Object.Module._extensions..js (internal/modules/cjs/loader.js:1138:10)
                                                                                                              at Module.load (internal/modules/cjs/loader.js:982:32)
                                                                                                          ↳ Error: editions-autoloader-none-suitable: Unable to determine a suitable edition, as none were suitable.

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 4, 2021

Happy to get this fixed asap. I'm not sure why istextorbinary is failing.

Can you create a minimum repro repo for this? Such as with electron-quick-start? It'd help a lot in debugging further locally.

@danatcofo
Copy link
Author

Yah I'll spend some cycles on this in the morning. Much rather not be version locked.

@danatcofo
Copy link
Author

So I've been working at this all day and basically came down and recreated the environment locally after trying to recreate with the electron-quick-start, electron.net source and my local project that is failing.

and nothing.... it works, it just simply works...

I have no idea why its working. however notably the only real difference in the ouput between local and the build server is the downolading of the files. locally, using my same commands I get no downloads of 11.1.1, winCodeSign, nsis or nsis-resouces, but the build server IS doing thos downloads during the electron-builder call

Powershell output locally, notice the lace of downloading calls.

Y:\repos\prefix-app\src\prefix-app\obj\desktop\win>npx electron-builder --config=./bin/electron-builder.json --win --x64 -c.electronVersion=11.1.1
  ΓÇó electron-builder  version=22.10.5 os=10.0.19042
  ΓÇó loaded configuration  file=Y:\repos\prefix-app\src\prefix-app\obj\desktop\win\bin\electron-builder.json
  ΓÇó description is missed in the package.json  appPackageFile=Y:\repos\prefix-app\src\prefix-app\obj\desktop\win\package.json
  ΓÇó packaging       platform=win32 arch=x64 electron=11.1.1 appOutDir=Y:\repos\prefix-app\dist\win-unpacked
  ΓÇó Unpacking electron zip  zipPath=undefined
  ΓÇó building        target=nsis file=Y:\repos\prefix-app\dist\stackify-prefix.exe archs=x64 oneClick=true perMachine=false
  ΓÇó building block map  blockMapFile=Y:\repos\prefix-app\dist\stackify-prefix.exe.blockmap
Y:\repos\prefix-app\src\prefix-app\obj\desktop\win>
... done

So, I'm kind of stumped here. feels more and more like I've got some weird edge case I should be able to tinker around with to get working.

any thoughts?

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 9, 2021

Hi @danatcofo, I'm honestly sure why the downloads would fail for electron-builder on local but not on the build server. It does indeed seem like an edge case.

Curious, if you change the electron version, would it still fail? Can you run with DEBUG=electron-builder and post what the logs throw out?

@AllinolCP
Copy link

I have a same issue on Mac while using this with github actions, any idea on how to fix this? (electron 11.3)

@vangberg
Copy link

I have the same issue on macOS with electron 12.0.1 and electron-builder 22.10.5. I would be happy to give @mmaietta access to the repo, if that helps.

@mmaietta
Copy link
Collaborator

Many thanks all for confirming the different electron + electron-builder versions, I appreciate it.
I'm working on setting up my Windows gaming machine for development so I can test this further.

@vangberg
Copy link

FWIW my issue was fixed by upgrading from Node 13.8.0 to 15.12.0.

@juwonjung-hdj
Copy link
Contributor

I have same issue when packing on electronuserland/builder:wine docker image with electron 12.0.1 and electron-builder 22.10.5.
Downgrading electron-builder version to 22.10.4 resolved issue.

Stack trace when build failed is following.

      Error: editions-autoloader-none-broadened: Unable to determine a suitable edition, even after broadening.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:317:21)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
      ↳ Error: editions-autoloader-none-suitable: Unable to determine a suitable edition, as none were suitable.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:327:19)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
      ↳ Error: editions-autoloader-edition-incompatible: editions-autoloader-edition-incompatible: The edition [TypeScript source code made to be compatible with Deno] is not compatible with this environment.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:301:25)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
      ↳ Error: editions-autoloader-edition-incompatible: editions-autoloader-edition-incompatible: The edition [TypeScript compiled against ES2019 for Node.js 12 || 14 || 15 with Import for modules] is not compatible with this environment.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:301:25)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
      ↳ Error: editions-autoloader-edition-incompatible: editions-autoloader-edition-incompatible: The edition [TypeScript compiled against ES2019 for Node.js 10 || 12 || 14 || 15 with Require for modules] is not compatible with this environment.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:301:25)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
      ↳ Error: editions-autoloader-edition-incompatible: editions-autoloader-edition-incompatible: The edition [TypeScript compiled against ESNext for Node.js 14 || 15 with Require for modules] is not compatible with this environment.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:301:25)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
      ↳ Error: editions-autoloader-edition-incompatible: editions-autoloader-edition-incompatible: The edition [TypeScript compiled against ES2019 for web browsers with Import for modules] is not compatible with this environment.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:301:25)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
      ↳ Error: editions-autoloader-edition-incompatible: The edition [TypeScript source code with Import for modules] is not compatible with this environment.
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at isCompatibleEdition (/project/node_modules/editions/edition-es5/index.js:252:19)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:287:4)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/project/node_modules/app-builder-lib/electron-osx-sign/util.js:135:22)
      ↳ Error: editions-autoloader-invalid-engines: The edition had no engines to compare against the environment
          at new Errlop (/project/node_modules/errlop/edition-es5/index.js:61:18)
          at Object.errtion (/project/node_modules/editions/edition-es5/util.js:23:14)
          at isCompatibleEngines (/project/node_modules/editions/edition-es5/index.js:183:19)
          at isCompatibleEdition (/project/node_modules/editions/edition-es5/index.js:250:10)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:287:4)
          at determineEdition (/project/node_modules/editions/edition-es5/index.js:312:12)
          at solicitEdition (/project/node_modules/editions/edition-es5/index.js:350:16)
          at Object.requirePackage (/project/node_modules/editions/edition-es5/index.js:364:9)
          at Object.<anonymous> (/project/node_modules/istextorbinary/index.cjs:4:38)
          at Module._compile (internal/modules/cjs/loader.js:738:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
          at Module.load (internal/modules/cjs/loader.js:630:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
          at Function.Module._load (internal/modules/cjs/loader.js:562:3)
          at Module.require (internal/modules/cjs/loader.js:667:17)
          at require (internal/modules/cjs/helpers.js:20:18)

c3er added a commit to c3er/mdview that referenced this issue Apr 5, 2021
The Linux version does not build with the current version 22.10.5.
It could be related to electron-builder issue #5668
electron-userland/electron-builder#5668
@F-fengzi
Copy link

Same thing happened for me, Travis CI, 22.10.5
Just updated to NodeJS 16.0 I'll try downgrading it.

@F-fengzi
Copy link

Thankfully this was fixed for me after downgrading NodeJS from 16.0.0 to 15.14.0.

@cliqer
Copy link

cliqer commented Apr 23, 2021

On Mac arm64 this is happening too.
It looks like a node v16 incompatibility just before the signing process

@NicolasNewman
Copy link

I've encountered the same problem as well with NodeJS v16.0.0 on Windows 10. Downgrading to v15.14.0 resolved the issue

@cliqer
Copy link

cliqer commented Apr 23, 2021

Unfortunately, this is not a solution.
Tried with brew, node.js direct download and n v15.14.0, v14.16.1.
On M1 everything misbehaves with any previous node versions.
Node v16 support is needed asap as it is the only one with arm64 support.

@michaelkozakovsc
Copy link

michaelkozakovsc commented Apr 25, 2021

Also having this issue on M1 mac mini and node 16. downgrading electron-builder to 22.10.4 fixes the issue.

@acrosman
Copy link

I'm having issues on node 16 on an Intel Mac. Rolling back to node 14 (since that's easy in brew) cleared it up.

@tognee
Copy link

tognee commented Apr 26, 2021

Same issue on Arch Linux using node 16

@llovvoll
Copy link

Same issue on mac OS node 16

@tognee
Copy link

tognee commented Apr 26, 2021

I think the title should be change to reflect this, as it's tagged as Windows only

@mebtte
Copy link

mebtte commented Apr 26, 2021

Same issue on macOS node@16, it works when I downgrade to node@14.

@F-fengzi
Copy link

for all having this issue right now, downgrade your nodeJS to anything below 16.0
or downgrading electron-builder to 22.10.4 might fix it as well, not sure

@InfraRedApple
Copy link

InfraRedApple commented Apr 28, 2021

On macOS: if you're running zsh open Terminal and type vim ~/.zshrc press <enter>

Next press i to insert and add the following line to the top of the file:
export PATH="$PATH:/usr/local/bin"

Then press esc and type :wq! and press <enter>

Close this Terminal window and open a new Terminal and re-run your command.

@MagiusCHE
Copy link

Same iussue here on Manjaro and NodeJs 16.

@develar
Copy link
Member

develar commented May 14, 2021

Should be fixed in 22.11.4

@develar develar closed this as completed May 14, 2021
@yf-hk
Copy link

yf-hk commented May 15, 2021

Tested working on windows with node 16

@acrosman
Copy link

Looks like this was fixed in 22.11.4 and a regression appeared in 22.11.5 that recreated the issue.

@jryans
Copy link
Contributor

jryans commented Jun 9, 2021

Looks like this was fixed in 22.11.4 and a regression appeared in 22.11.5 that recreated the issue.

It doesn't seem like there's any open issue tracking the new regression here... Should this be reopened, or should a new issue be filed?

@quinton-ashley
Copy link

This sucks, electron-builder breaks all the time and node-abi is always out of date.

@mboutin-qohash
Copy link

mboutin-qohash commented Jun 18, 2021

@quinton-ashley Can you do better? Theses packages depends on A LOT of stuff and we are very lucky to have this team. Please be constructive on repos you don't own.

@acrosman
Copy link

Folks who want to be productive about this should probably re-test against 22.11.7 (the current version as of this message) and if the issue continues open a new issue for the bug. Include a reference to this issue and the fact that it appears to have been a regression in 22.11.5 to help the developers search for the breaking change. I haven't had the time to do that myself in part because 22.11.4 still works for my project.

@alice-viola
Copy link

Same here on MacOS 10.15.2, Node 16. Downgrading to Node 15.14.0 works

@acrosman
Copy link

I ran the experiment I mentioned in my previous post and the build appears to work properly with 22.11.7 on Mac OS 10.15.7, Node 16.1, and an Intel processor. So if you're seeing problems you probably need to first update all the related tools and then if still having trouble provide more details (and given the developer's choice not to re-open this issue file a new one with the details needed to reproduce the problem).

@mingley
Copy link

mingley commented Sep 3, 2021

FWIW my issue was fixed by upgrading from Node 13.8.0 to 15.12.0.

I have this issue when using node 16 but on current LTS as of this posting(v14) it works fine.

facebook-github-bot pushed a commit to facebook/flipper that referenced this issue Nov 2, 2021
Summary: `yarn build --mac` started failing with errors. This fixes it. Probable root cause: electron-userland/electron-builder#5668

Reviewed By: aigoncharov

Differential Revision: D32101006

fbshipit-source-id: 50011f8be8079bd96c8f602002ccb500c3ad4794
filipesilva added a commit to athensresearch/athens that referenced this issue Dec 9, 2021
CI seemed to be running into
electron-userland/electron-builder#5668,
likely due to the github CI images being updated to node 16.

We can either pin the node version used or update electron-builder, and
the latter seems the more future facing approach.
luxuereal added a commit to luxuereal/md_viewer_electron that referenced this issue Jun 16, 2023
The Linux version does not build with the current version 22.10.5.
It could be related to electron-builder issue #5668
electron-userland/electron-builder#5668
@Sarthhak03
Copy link

Same here on my angular + electron app , Node 16 , Downgraded to Node 15.14.0, now working fine .

luxuereal added a commit to luxuereal/md_viewer_electron that referenced this issue Dec 12, 2023
The Linux version does not build with the current version 22.10.5.
It could be related to electron-builder issue #5668
electron-userland/electron-builder#5668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests