Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron-builder for Node 16 compatibility #204

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

chayleaf
Copy link
Contributor

@chayleaf chayleaf commented Jun 7, 2021

Original issue: electron-userland/electron-builder#5668

Signed-off-by: Ivan Pavluk chayleaf@protonmail.com

@t3chguy t3chguy requested a review from a team June 7, 2021 16:29
Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall looks good to me, just one more tweak. Please re-request review when updated.

@chayleaf chayleaf requested a review from jryans June 10, 2021 17:31
@jryans
Copy link
Contributor

jryans commented Jun 11, 2021

@pavlukivan Looks great, but I forgot one more thing: can you please also add your sign off as described in CONTRIBUTING.rst? You can either edit the top message of the PR, or update the commits. Thanks!

@chayleaf
Copy link
Contributor Author

done

Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for working on this! 😄

@jryans jryans merged commit b2f0957 into element-hq:develop Jun 11, 2021
@jryans jryans mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants