Fix: handle dependencies with package 'link' fields #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2018 15:08
… set in package.json Some projects, like Mozilla Aframe, set a 'link' property at the root of their package.json file. This causes problems for our packageDependencies job, which extends that object and adds 'link' to signify the dependency dir is a symlink. Overwrite property by default. Closes #2685
jbreckmckye
changed the title
jbreckmckye
changed the title
|
Thanks! 20.5.1 released. |
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked bug: #2685
Some projects, like Mozilla Aframe, set a 'link' property at the root of their package.json file.
This causes problems for our packageDependencies job, which extends that object and adds 'link'
to signify the dependency dir is a symbolic link.
This PR makes sure any existing
linkin package.json is always overwritten with the appropriate value.