Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: handle dependencies with package 'link' fields #2690

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Fix: handle dependencies with package 'link' fields #2690

merged 2 commits into from
Mar 14, 2018

Commits on Mar 13, 2018

  1. fix: when parsing dependencies, overwrite any 'link' property already… 

    … set in package.json

Some projects, like Mozilla Aframe, set a 'link' property at the root of their package.json file.
This causes problems for our packageDependencies job, which extends that object and adds 'link'
to signify the dependency dir is a symlink. Overwrite property by default.

Closes #2685
    jbreckmckye committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    70cb056 View commit details
    Browse the repository at this point in the history

  2. Accidental commit

    jbreckmckye committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    46601b2 View commit details
    Browse the repository at this point in the history