Fix-[#4068]:NSIS Uninstaller registry entry format change

[abhishekmatcha]

1. In windows Registry entry for uninstaller is located at this path
   Software\Microsoft\Windows\CurrentVersion\Uninstall\ with just the guid as Example: \SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\ddd366r9-367b-5d51-b552-9754365 but the convention to store the key with id in registry is \SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\\{ddd366r9-367b-5d51-b552-9754365}.

[mastergberry]

@abhishekmatcha this MR caused an issue it seems where there is a glitched entry now for the old GUID still in the Programs & Features section.

New format:

HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{1de14785-dd8c-5cd2-aae8-d4a376f81d78}

Old format:

HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\1de14785-dd8c-5cd2-aae8-d4a376f81d78

Unfortunately any users that upgraded from the old to new format have now 2 "installations" in their Programs & Features on Windows. They can't remove the second one though, because the first actually already did the uninstallation.

For now I am writing a one time script in nsis to clean up this old bugged entry for my application...but this should probably be fixed for everyone too.

[pronebird]

Yeah what a bloody mess. Why would this be merged without a migration path?

[andrienko]

This basically means that we can not update electron-builder beyond 21.1.2, because it corrupts the nsis updates from versions built with older version (because of the reg keys changed and it does not clean the installation folder prior to installation).

Also, we can't use the electron v6, because it requires at least electron-builder version 22, otherwise it crashes on MacOS.

Nice.

[damianobarbati]

@andrienko I'm stuck as well: can't downgrade because of hardenedRuntime needed by Catalina: did you find solution?

[menelike]

@andrienko

We're in the same situation. #4443 addresses this, but afaik the only current solution to this is to backport that change in (your own fork) 21.2.0. Then compile, submodule & local npm install app-builder-lib from that. You could also publish a backported version on npm. Whatever you/we currently choose, it's a mess...

[laurent22]

Why was this pull request merged in such a careless way? No review, no question asked, just merge without thinking of the consequences. What a complete mess, and not a word from the maintainers on how to fix this.