Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug #7711. #7763

Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix: bug #7711. #7763

merged 3 commits into from
Sep 25, 2023

Conversation

NewSilen
Copy link
Contributor

@NewSilen NewSilen commented Sep 4, 2023

Windows build will fail because the icon.ico will put to ${version}/.icon-ico/ dir, not x.x.x/.icon-ico/ dir.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

🦋 Changeset detected

Latest commit: b3ad8a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit b3ad8a8
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6511f4a3dfbf88000822143e
😎 Deploy Preview https://deploy-preview-7763--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NewSilen NewSilen changed the title fix bug 7711. fix: bug #7711. Sep 4, 2023
@mmaietta
Copy link
Collaborator

Thanks for your contribution!

Please resolve compiler errors when you have a chance, thank you!

@mmaietta mmaietta merged commit 0cb1913 into electron-userland:master Sep 25, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants