Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug #7711. #7763

Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix: bug #7711. #7763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10e2195
fix bug 7711.
Sep 4, 2023
fead535
'output' is never reassigned. Use 'const' instead
Sep 20, 2023
b3ad8a8
Create yellow-games-beg.md
mmaietta Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/yellow-games-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: expand macro for ${version}/.icon-ico/ dir on Window's installers
3 changes: 2 additions & 1 deletion packages/app-builder-lib/src/platformPackager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@

// convert if need, validate size (it is a reason why tool is called even if file has target extension (already specified as foo.icns for example))
async resolveIcon(sources: Array<string>, fallbackSources: Array<string>, outputFormat: IconFormat): Promise<Array<IconInfo>> {
const output = this.expandMacro(this.config.directories!.output!);

Check warning on line 682 in packages/app-builder-lib/src/platformPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura... 

Delete `;`

Check warning on line 682 in packages/app-builder-lib/src/platformPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (snapTest,debTest,fpmTest,protonTest) 

Delete `;`
const args = [
"icon",
"--format",
Expand All @@ -688,7 +689,7 @@
"--root",
this.projectDir,
"--out",
path.resolve(this.projectDir, this.config.directories!.output!, `.icon-${outputFormat}`),
path.resolve(this.projectDir, output, `.icon-${outputFormat}`),
]
for (const source of sources) {
args.push("--input", source)
Expand Down