fix(webpack-plugin): add web as a target for the renderer process (#2285

)
electron · May 23, 2021 · 9f2bc41 · 9f2bc41
1 parent 7bbff3a
commit 9f2bc41
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/plugin/webpack/src/WebpackConfig.ts b/packages/plugin/webpack/src/WebpackConfig.ts
@@ -215,7 +215,7 @@ export default class WebpackConfigGenerator {
  return webpackMerge({
  entry,
  devtool: this.sourceMapOption(),
- target: 'electron-renderer',
+ target: ['web', 'electron-renderer'],
  mode: this.mode,
  output: {
  path: path.resolve(this.webpackDir, 'renderer'),

diff --git a/packages/plugin/webpack/test/WebpackConfig_spec.ts b/packages/plugin/webpack/test/WebpackConfig_spec.ts
@@ -352,7 +352,7 @@ describe('WebpackConfigGenerator', () => {
  } as WebpackPluginConfig;
  const generator = new WebpackConfigGenerator(config, mockProjectDir, false, 3000);
  const webpackConfig = await generator.getRendererConfig(config.renderer.entryPoints);
- expect(webpackConfig.target).to.equal('electron-renderer');
+ expect(webpackConfig.target).to.deep.equal(['web', 'electron-renderer']);
  expect(webpackConfig.mode).to.equal('development');
  expect(webpackConfig.entry).to.deep.equal({
  main: ['rendererScript.js'],
@@ -397,7 +397,7 @@ describe('WebpackConfigGenerator', () => {
  } as WebpackPluginConfig;
  const generator = new WebpackConfigGenerator(config, mockProjectDir, true, 3000);
  const webpackConfig = await generator.getRendererConfig(config.renderer.entryPoints);
- expect(webpackConfig.target).to.equal('electron-renderer');
+ expect(webpackConfig.target).to.deep.equal(['web', 'electron-renderer']);
  expect(webpackConfig.mode).to.equal('production');
  expect(webpackConfig.entry).to.deep.equal({
  main: ['rendererScript.js'],