Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack-plugin): add web as a target for the renderer process #2285

Merged
merged 1 commit into from
May 23, 2021

Conversation

malept
Copy link
Member

@malept malept commented May 23, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #2284

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #2285 (6567197) into master (7bbff3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2285   +/-   ##
=======================================
  Coverage   75.59%   75.59%           
=======================================
  Files          74       74           
  Lines        2200     2200           
  Branches      413      413           
=======================================
  Hits         1663     1663           
  Misses        421      421           
  Partials      116      116           
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackConfig.ts 97.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbff3a...6567197. Read the comment docs.

@malept malept merged commit 9f2bc41 into master May 23, 2021
@malept malept deleted the malept/fix/webpack-plugin/renderer-target-require branch May 23, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.0.0-beta.56 throws error require is not defined in the console
1 participant