Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publisher-s3): ensure files are on disk before publishing #2585

Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix(publisher-s3): ensure files are on disk before publishing #2585

merged 1 commit into from
Nov 8, 2022

Conversation

zakdoek
Copy link
Contributor

@zakdoek zakdoek commented Oct 18, 2021 •
edited
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

When making with windows.squirrel and the noDelta options selected, the
delta package will end up in the artifacts list and kill the publishing
phase. Although unrelated, this will only publish files that are
actually on disk at the time of publishing.

@zakdoek
fix: 🐛 Let S3 Publisher publish only existing files
08db3f4 
When making with windows.squirrel and the noDelta options selected, the
delta package will end up in the artifacts list and kill the publishing
phase. Although unrelated, this will only publish files that are
actually on disk at the time of publishing.
@erickzhao erickzhao changed the title fix: 🐛 Let S3 Publisher publish only existing files fix(publisher-s3): ensure files are on disk before publishing Nov 8, 2022
@erickzhao erickzhao merged commit 7f8559e into electron:main Nov 8, 2022
VerteDinde pushed a commit that referenced this pull request Nov 8, 2022
@zakdoek @VerteDinde
fix(publisher-s3): ensure files are on disk before publishing (#2585)
f3d38e0 
When making with windows.squirrel and the noDelta options selected, the
delta package will end up in the artifacts list and kill the publishing
phase. Although unrelated, this will only publish files that are
actually on disk at the time of publishing.

Co-authored-by: Tom Van Damme <tom.vandamme@two-point-o.be>
MarshallOfSound added a commit that referenced this pull request Nov 9, 2022
@MarshallOfSound
Revert "fix(publisher-s3): ensure files are on disk before publishing (…
76357e5 
…#2585)"

This reverts commit f3d38e0.
MarshallOfSound added a commit that referenced this pull request Nov 9, 2022
@MarshallOfSound
fix(maker-squirrel): do not register the delta nupkg as an artifact w…
5559449 
…hen deltas are disabled (#3059)

* Revert "fix(publisher-s3): ensure files are on disk before publishing (#2585)"

This reverts commit f3d38e0.

* fix: do not add delta package to list if noDelta is specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zakdoek @erickzhao