fix(maker-squirrel): do not register the delta nupkg as an artifact when deltas are disabled #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
approved these changes
Nov 9, 2022
malept
reviewed
Nov 9, 2022
erickzhao
approved these changes
Nov 9, 2022
|
@malept Adding testing infra for delta packages is a lot of either effort or test runtime or both. We could probably test the "no delta" case but we can't easily test the "build me a delta" case without a valid There is generically a lot to do with our tests, in particular the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better fix for f3d38e0 that doesn't just drop all missing files for a single publisher, rather is ensures the maker does not erroneously add the file to the artifacts list in the first place.