feat(template): add vite template

[caoxiemeihao]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Addresses #2954

Summarize your changes:

Support --template=vite :)

Hi! here. 👋
@erickzhao @VerteDinde
Some additional help is needed here.

1. not sure if the design of VitePluginConfig makes sense, it references WebpackPluginConfig.
2. I think more configuration should be left to the user to implement in vite.config.xxx rather than integrated in the template.
3. @electron-forge/plugin-vite needs to write test code

[VerteDinde]

Left a few initial comments, but the overall approach looks good to me! Thanks so much for doing this work! 🙇‍♀️

To answer #2:

I think more configuration should be left to the user to implement in vite.config.xxx rather than integrated in the template.

I'm fine with this approach, especially for more experienced Vite users, it will allow them more customization options. We can always make the template more or less opinionated in later drafts.

[erickzhao]

not sure if the design of VitePluginConfig makes sense, it references WebpackPluginConfig.

In my opinion, the WebpackPluginConfig design could use some improvement. For example, why are config.mainConfig and config.renderer.config named that way? It's not very intuitive.

I think more configuration should be left to the user to implement in vite.config.xxx rather than integrated in the template.

I think this is a good initial approach. We can always add more Forge-specific configuration if needed.

[caoxiemeihao]

Here! 👋
I provided a temporary running solution, it will be a good playground until we finally complete this PR.

1. yarn global add electron-forge-template-vite
2. yarn create electron-app --template=vite

[erickzhao]

I removed the wip from the template because the check prevents CI from running until you remove it!

We're thinking of removing it in the long term now that Draft PRs are a builtin GitHub feature.

[erickzhao]

@caoxiemeihao can you rebase with the latest main? I'll give it another review tomorrow!

[caoxiemeihao]

@erickzhao Yep! Good night!

[caoxiemeihao]

#3071 (comment)
But then again, I think it's ultimately necessary to flat the configuration, which would not only make it more flexible, but also reduce the complexity of Vite integration. Otherwise we might need to write a lot of built-in plugins to fit vite serve and vite build.

[sipt]

@caoxiemeihao
index.html not found.

1. yarn global add electron-forge-template-vite
2. yarn create electron-app template --template=vite
3. cd template
4. yarn make
5. open out/template-darwin-x64/template.app
   
   

[caoxiemeihao]

@sipt I will try to fix it tomorrow.

---

@sipt Hey! 👋
You can try use latest version.

[sipt]

How to use 'yarn make' without copy source code? @caoxiemeihao

[warrenbuckley]

Hiya 👋
I am just following along here, what is the latest status of this PR?
Can I expect it to be merged into Electron Forge soon @erickzhao @caoxiemeihao ?

[erickzhao]

@warrenbuckley we're hopefully looking to getting this PR merged soon. Currently going through the code review process.

[martinszeltins]

@warrenbuckley we're hopefully looking to getting this PR merged soon. Currently going through the code review process.

Awesome, can't wait for this! Also, there should be a TypeScript option.

[erickzhao]

I think CI is failing we bumped the version up to 6.1.0, but it should be aligned with the rest of the monorepo package versions (6.0.5). We use syncpack to enforce that:

https://www.npmjs.com/package/syncpack

The version number will be automatically bumped by Lerna during the publishing process!

[BlackHole1]

LGTM. Thanks, @caoxiemeihao!

[martpie]

Any hope to see this officially released soon? Very eager to give it a try :]