Skip to content

Commit

Permalink
feat: add ABI number for Electron ^4.0.4 (#57)
Browse files Browse the repository at this point in the history 
See: electron/electron#16687
  • Loading branch information
@malept @MarshallOfSound
malept authored and MarshallOfSound committed Feb 3, 2019
1 parent 458f2eb commit 9e4c1a6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ var supportedTargets = [
{runtime: 'electron', target: '1.8.0', abi: '57', lts: false},
{runtime: 'electron', target: '2.0.0', abi: '57', lts: false},
{runtime: 'electron', target: '3.0.0', abi: '64', lts: false},
{runtime: 'electron', target: '4.0.0', abi: '64', lts: false}
{runtime: 'electron', target: '4.0.0', abi: '64', lts: false},
{runtime: 'electron', target: '4.0.4', abi: '69', lts: false}
]

var additionalTargets = [
Expand Down

3 comments on commit 9e4c1a6

@jacobq
Copy link
Contributor

@jacobq jacobq commented on 9e4c1a6 Apr 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarshallOfSound is this off-by-one?
If I'm reading https://github.com/nodejs/node/blob/master/doc/abi_version_registry.json right then electron v4.0.4 should match 64 and v4.0.5 should match 69. (I noticed this while writing a PR to update the test suite and now am not sure what the correct behavior should be.)

{ "modules": 69, "runtime": "electron", "variant": "electron",  "versions": "^4.0.5" },
{ "modules": 64, "runtime": "electron", "variant": "electron",  "versions": ">=3 <4.0.5" },

@jacobq
Copy link
Contributor

@jacobq jacobq commented on 9e4c1a6 Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is correct: Electron v4.0.4 should match 69 (https://github.com/electron/electron/releases/tag/v4.0.4 & electron/electron#16687) but doesn't that mean that the "official registry" is incorrect? Or am I somehow reading that wrong?

@jacobq
Copy link
Contributor

@jacobq jacobq commented on 9e4c1a6 Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened nodejs/node#27394

Please sign in to comment.