fix: correct ABI entry for electron v4.0.4 #27394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * electron/electron#16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * electron/node-abi@9e4c1a6
jacobq
referenced
this pull request
in electron/node-abi
Apr 24, 2019
jasnell
approved these changes
Apr 26, 2019
|
Looks like a test is failing because of the way I formatted my commit message. I enabled the "Allow edits from maintainers" option. Could someone revise it and rebase/amend? Otherwise let me know what I should've written instead (not sure what the subsystems are nor which one would be most appropriate here). |
|
@jacobq You can ignore the commit message complaint – providing a commit message formatted according to our rules is the responsibility of the person who lands this, not the author’s. I’ll resume CI to get rid of the other failures. |
addaleax
approved these changes
May 3, 2019
addaleax
added
addons
|
Sorry it took so long! Landed in 4a7b8ea 🎉 |
addaleax
pushed a commit
that referenced
this pull request
May 19, 2019
`abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * electron/electron#16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * electron/node-abi@9e4c1a6 PR-URL: #27394 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
May 20, 2019
`abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * electron/electron#16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * electron/node-abi@9e4c1a6 PR-URL: #27394 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abi_version_registry.jsonincorrectly specified that electron v4.0.4 usedNODE_MODULE_VERSION64, but in fact it uses 69.See:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes