-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New lifecycle hooks: afterAsar, afterComplete, afterCopyExtraResources, beforeAsar, beforeCopy, beforeCopyExtraResources #1297
Conversation
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #1297 +/- ##
==========================================
+ Coverage 95.47% 95.54% +0.06%
==========================================
Files 15 15
Lines 774 785 +11
==========================================
+ Hits 739 750 +11
Misses 35 35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If there's anything I can do to help move this along, please let me know. 🙂 |
…lete, afterCopyExtraResources, beforeAsar, beforeCopy, beforeCopyExtraResources
e3c0490
to
300566f
Compare
Thanks for your contribution! 🎉 |
Summarize your changes:
This PR partially addresses #509 with the following new lifecycle methods:
afterAsar
,afterComplete
,afterCopyExtraResources
,beforeAsar
,beforeCopy
,beforeCopyExtraResources
. There's definitely room for improvement, so any feedback is welcome.