-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make notifications spoiler aware #4426
Make notifications spoiler aware #4426
Conversation
Hello @paftree, thanks for the PR. |
Added more screenshots above. |
for my own understanding, does this change only hide spoilers in the direct message/room list and notifications? (all the places that use The spoilers will still be visible within the message timeline? |
Right, the current behavior is using the unformatted message body in the room list/notifications where most clients will just put the spoiler verbatim... which somewhat defeats the point of having spoiler text at all. This change attempts to replace any spoiler text with fullblock characters in non-html-formatted places. The actual message in the room will still be hidden/viewable by the data-mx-spoiler attribute. |
Merge on one of my branch, will create a new PR soon |
An attempt to implement matrix-org/matrix-spec-proposals#3124, and address #3477
Signed-off-by: Preston Frazier @preston:inferiorlattice.com
Pull Request Checklist