Message previews spoil spoilers

[turt2live]

No description provided.

[janogarcia]

@turt2live Unsure about the technical implications but I'd suggest changing the visual rendering from

Plain text

to

Spoiler ██████████

[SimonBrandner]

A problem here could be that a part of a message can be a spoiler, not necessarily the whole message, what would things look like then?

[janogarcia]

@SimonBrandner I wasn't aware of that, I though the whole message would always get hidden. Thanks for flagging it, Simon. In that case the workaround I suggested doesn't make sense. We should only obscure the relevant part.

Also, just to clarify it, I'm not suggesting using actual full block characters █ as that's probably an awful idea accessibility-wise. It was a quick way to represent the visual spoiler effect.

[SimonBrandner]

So if I understand you correctly we would just blur the spoiler part of the message in the preview the same way we do in the timeline. Though we wouldn't allow clicking the spoiler to reveal it the same way we do in the timeline

Thanks for looking into this!

[janogarcia]

@SimonBrandner We'll need to revisit this at a later point in time. It's not a top priority right now, but it will be considered once we start working on improving the rendering of the different content types and formatting styles across all the different contexts: element-hq/element-meta#121

[gabrc52]

The merged Android PR element-hq/element-android#4426 fixes the Android equivalent of this issue and #12034 (screenshots from the PR are below)

While spoilers are used occassionally as it says in the labels, I believe that spoilers are a special case that deserves a change without necessarily needing an entire overhaul in Element content rendering. Showing the text of spoilers in previews defeats the point of spoilers, and Element Web and Desktop should reach feature parity with Android and hide spoilers too.

I could look into submitting a PR, but I'm unsure which repo would need changing. If so, let me know if such a change would be reviewed and merged (I assume so from "help wanted" label) or if you would instead wait until element-hq/element-meta#121 is resolved.