Discard fallback body for HTML messages, and generate a spoiler-free plaintext representation to use locally in the UI #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…free version Signed-off-by: xenofem <xenofem@xeno.science>
|
Retracting this PR, the |
|
Did you make a PR in matrix-react-sdk? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes element-hq/element-web#12034 , I'm unclear on how to reproduce element-hq/element-web#14447 but I'm fairly sure this will fix that issue as well.
I've deliberately done the HTML-to-text conversion in a very fast-and-loose way, since the text version is only needed in a few limited contexts and doesn't need to do much more than give a general gist of the message content. If you'd rather retain a bit more formatting information, perhaps in a markdown-like syntax, I can adjust things.