Add the livekit URL in matroyshka mode #1225
Conversation
This is a bit of a hack, as commented. The way to make it less of a hack is there too. Fixes embedded mode, although users will get a permission prompt without matrix-org/matrix-react-sdk#11209. Fixes #1201
dbkr
added
the
T-Defect
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## livekit #1225 +/- ##
==========================================
Coverage ? 25.38%
==========================================
Files ? 48
Lines ? 1950
Branches ? 297
==========================================
Hits ? 495
Misses ? 1425
Partials ? 30
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
|
||
| const clientPromise = new Promise<MatrixClient>((resolve) => { | ||
| (async () => { | ||
| await Config.init(); |
There was a problem hiding this comment.
this seems to be redundant with what the initializer is doing? do we not have the initializer in embedded mode?
There was a problem hiding this comment.
This migh result in duplicated downloads of the json right?
There was a problem hiding this comment.
Config.init has a few lines that look like this:
if (Config.internalInstance?.initPromise) {
return Config.internalInstance.initPromise;
}so that doesn't appear to be the case. If there's already a request promise in flight, it returns that same promise.
This is a bit of a hack, as commented. The way to make it less of a hack is there too.
Fixes embedded mode, although users will get a permission prompt without matrix-org/matrix-react-sdk#11209.
Fixes #1201