Ship linux tarball with static sqlcipher #597

t3chguy · 2023-03-30T09:26:13Z

Fixes element-hq/element-web#18486

Here's what your changelog entry will look like:

✨ Features

Ship linux tarball with static sqlcipher (#597). Fixes Build desktop app to tarball for non-debian element-web#18486.

t3chguy · 2023-03-30T16:20:12Z

e.g. https://packages-element-io-test.element.io/nightly/install/linux/glibc-x86-64/element-desktop-nightly.tar.gz

t3chguy · 2023-03-30T16:28:09Z

This should make it easier for some other packagers to maintain their packages

…fix/18486

.github/workflows/build_and_deploy.yaml

MatMaul · 2023-04-03T08:19:17Z

seshat can't be loaded because there is still a non-static dependency, libcrypto.so.1.1:

ldd resources/app.asar.unpacked/node_modules/matrix-seshat/native/index.node
	linux-vdso.so.1 (0x00007ffdebcd2000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f95ce72d000)
	libcrypto.so.1.1 => not found
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f95ce728000)
	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f95ce704000)
	librt.so.1 => /lib64/librt.so.1 (0x00007f95ce6ff000)
	libm.so.6 => /lib64/libm.so.6 (0x00007f95ce61e000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f95cdc21000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f95ce742000)

t3chguy · 2023-04-03T08:30:06Z

Yeah we're not going to statically link the world here, there lacks documentation for what remaining dependencies this bundle has @MatMaul

MatMaul · 2023-04-03T09:15:47Z

I just understood that it is openssl. This one is quite annoying since 1.1 was used everywhere for quite a while, but now most of the distribs have moved on to 3.0.

Using feature bundled-sqlcipher-vendored-openssl for rusqlite dependency of seshat should do it I believe.
https://github.com/rusqlite/rusqlite/tree/master#optional-features

MatMaul · 2023-04-03T09:59:34Z

@t3chguy this should help moving further. Then we can replace SQLCIPHER_STATIC=1 with enabling the feature instead.

t3chguy · 2023-04-03T12:26:37Z

@MatMaul happy for you to chase that if it is something of value to you - not something I'll have time to any time soon. https://github.com/vector-im/element-desktop/blob/develop/docs/native-node-modules.md#statically-linking-libsqlcipher documents the requirement for libcrypto1.1

https://build.opensuse.org/request/show/1079443 by user dheidler + dimstar_suse - Version 1.11.29 ## ✨ Features * Ship linux tarball with static sqlcipher ([\#597](element-hq/element-desktop#597)). Fixes element-hq/element-web#18486. * Show recent room breadcrumbs on touchbar ([\#183](element-hq/element-desktop#183)). Fixes element-hq/element-web#15998. * Clear electron data when logging out ([\#578](element-hq/element-desktop#578)). * Send Electron crashpad reports to Sentry from Nightly ([\#579](element-hq/element-desktop#579)). Fixes element-hq/element-web#18263. * Recommend element-io-archive-keyring from our Debian package ([\#566](element-hq/element-desktop#566)). * Allow desktop app to expose recent rooms in UI integrations ([\#16940](https://git

@dhenneke

* Ship linux tarball with static sqlcipher ([\element-hq#597](element-hq#597)). Fixes element-hq/element-web#18486. * Show recent room breadcrumbs on touchbar ([\element-hq#183](element-hq#183)). Fixes element-hq/element-web#15998. * Clear electron data when logging out ([\element-hq#578](element-hq#578)). * Send Electron crashpad reports to Sentry from Nightly ([\element-hq#579](element-hq#579)). Fixes element-hq/element-web#18263. * Recommend element-io-archive-keyring from our Debian package ([\element-hq#566](element-hq#566)). * Allow desktop app to expose recent rooms in UI integrations ([\#16940](element-hq/element-web#16940)). * Add API params to mute audio and/or video in Jitsi calls by default ([\#24820](element-hq/element-web#24820)). Contributed by @dhenneke. * Style mentions as pills in rich text editor ([\#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk. * Mentions as links rte ([\#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\#10425](matrix-org/matrix-react-sdk#10425)). Fixes element-hq/element-web#10559. * Mentions as links rte ([\#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\#9983](matrix-org/matrix-react-sdk#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\#10392](matrix-org/matrix-react-sdk#10392)). Fixes element-hq/element-web#24751 and element-hq/element-web#24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\#6084](matrix-org/matrix-react-sdk#6084)). Fixes element-hq/element-web#17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\#10380](matrix-org/matrix-react-sdk#10380)). Fixes element-hq/element-web#24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\#10388](matrix-org/matrix-react-sdk#10388)). Fixes element-hq/element-web#24825. * Poll history - access poll history from room settings ([\#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam. * Run build_linux in docker using an older glibc ([\element-hq#599](element-hq#599)). Fixes element-hq/element-web#24981. * Use a newly generated access_token while joining Jitsi ([\#24646](element-hq/element-web#24646)). Fixes element-hq/element-web#24687. Contributed by @emrahcom. * Fix cloudflare action pointing at commit hash instead of tag ([\#24777](element-hq/element-web#24777)). Contributed by @justjanne. * Allow editing with RTE to overflow for autocomplete visibility ([\#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes element-hq/element-web#24995. * Properly generate mentions when editing a reply with MSC3952 ([\#10486](matrix-org/matrix-react-sdk#10486)). Fixes element-hq/element-web#24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\#10419](matrix-org/matrix-react-sdk#10419)). Fixes element-hq/element-web#20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\#10476](matrix-org/matrix-react-sdk#10476)). Fixes element-hq/element-web#24921. * Fix decryption failure bar covering the timeline ([\#10360](matrix-org/matrix-react-sdk#10360)). Fixes element-hq/element-web#24780 element-hq/element-web#24074 and element-hq/element-web#24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\#10470](matrix-org/matrix-react-sdk#10470)). Fixes element-hq/element-web#24919. * Handle group call redaction ([\#10465](matrix-org/matrix-react-sdk#10465)). * Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes element-hq/element-web#24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\#10424](matrix-org/matrix-react-sdk#10424)). Fixes element-hq/element-web#24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\#10457](matrix-org/matrix-react-sdk#10457)). Fixes element-hq/element-web#24959. * Fix "show read receipts sent by other users" not applying to threads ([\#10445](matrix-org/matrix-react-sdk#10445)). Fixes element-hq/element-web#24910. * Fix joining public rooms without aliases in search dialog ([\#10437](matrix-org/matrix-react-sdk#10437)). Fixes element-hq/element-web#23937. * Add input validation for `m.direct` in `DMRoomMap` ([\#10436](matrix-org/matrix-react-sdk#10436)). Fixes element-hq/element-web#24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\#10211](matrix-org/matrix-react-sdk#10211)). Fixes element-hq/element-web#24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\#10423](matrix-org/matrix-react-sdk#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\#10396](matrix-org/matrix-react-sdk#10396)). Fixes element-hq/element-web#14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes element-hq/element-web#24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\#10404](matrix-org/matrix-react-sdk#10404)). Fixes element-hq/element-web#22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\#10353](matrix-org/matrix-react-sdk#10353)). Fixes element-hq/element-web#24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\#10373](matrix-org/matrix-react-sdk#10373)). Fixes element-hq/element-web#24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\#10394](matrix-org/matrix-react-sdk#10394)). Fixes element-hq/element-web#24397. * Fix `[object Object]` in feedback metadata ([\#10390](matrix-org/matrix-react-sdk#10390)). * Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes element-hq/element-web#24615. * Fix import e2e key dialog staying disabled after paste ([\#10375](matrix-org/matrix-react-sdk#10375)). Fixes element-hq/element-web#24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\#10369](matrix-org/matrix-react-sdk#10369)). Fixes element-hq/element-web#24813. * Fix UIFeature.Registration not applying to all paths ([\#10371](matrix-org/matrix-react-sdk#10371)). Fixes element-hq/element-web#24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\#10359](matrix-org/matrix-react-sdk#10359)). Fixes element-hq/element-web#24797. * Fix start DM with pending third party invite ([\#10347](matrix-org/matrix-react-sdk#10347)). Fixes element-hq/element-web#24781. * Fix long display name overflowing reply tile on IRC layout ([\#10343](matrix-org/matrix-react-sdk#10343)). Fixes element-hq/element-web#24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\#9016](matrix-org/matrix-react-sdk#9016)). Fixes element-hq/element-web#24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\#10308](matrix-org/matrix-react-sdk#10308)).

t3chguy added 2 commits March 30, 2023 09:13

Ship linux tarball with static sqlcipher

dfae907

Test

e1ed2aa

t3chguy added the T-Enhancement label Mar 30, 2023

t3chguy had a problem deploying to packages.element.io March 30, 2023 10:03 — with GitHub Actions Failure

t3chguy closed this Mar 30, 2023

t3chguy reopened this Mar 30, 2023

t3chguy temporarily deployed to packages.element.io March 30, 2023 11:15 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 11:17 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 11:31 — with GitHub Actions Inactive

t3chguy had a problem deploying to packages.element.io March 30, 2023 11:32 — with GitHub Actions Failure

Merge branch 'develop' into t3chguy/fix/18486

134c381

t3chguy temporarily deployed to packages.element.io March 30, 2023 13:25 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 13:26 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 13:46 — with GitHub Actions Inactive

t3chguy had a problem deploying to packages.element.io March 30, 2023 13:47 — with GitHub Actions Failure

t3chguy temporarily deployed to packages.element.io March 30, 2023 15:53 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 15:55 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 16:08 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 16:09 — with GitHub Actions Inactive

t3chguy marked this pull request as ready for review March 30, 2023 16:28

t3chguy requested a review from a team as a code owner March 30, 2023 16:28

t3chguy requested a review from justjanne March 30, 2023 16:28

t3chguy added 2 commits March 30, 2023 18:00

Revert test bucket changes

ac3dd0d

Merge remote-tracking branch 'origin/t3chguy/fix/18486' into t3chguy/…

0090e93

…fix/18486

t3chguy temporarily deployed to packages.element.io March 30, 2023 17:00 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 17:02 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 17:16 — with GitHub Actions Inactive

t3chguy temporarily deployed to packages.element.io March 30, 2023 17:17 — with GitHub Actions Inactive

justjanne reviewed Mar 31, 2023

View reviewed changes

.github/workflows/build_and_deploy.yaml Outdated Show resolved Hide resolved

Update build_and_deploy.yaml

9582edb

t3chguy requested a review from justjanne March 31, 2023 09:46

justjanne approved these changes Mar 31, 2023

View reviewed changes

t3chguy merged commit c10e666 into develop Mar 31, 2023

t3chguy deleted the t3chguy/fix/18486 branch March 31, 2023 10:00

t3chguy mentioned this pull request May 12, 2023

Flatpak Distribution #656

Open

julianfairfax mentioned this pull request Aug 30, 2023

Build app to arm64 tarball #1190

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ship linux tarball with static sqlcipher #597

Ship linux tarball with static sqlcipher #597

t3chguy commented Mar 30, 2023 •

edited by github-actions bot

Loading

t3chguy commented Mar 30, 2023

t3chguy commented Mar 30, 2023

MatMaul commented Apr 3, 2023

t3chguy commented Apr 3, 2023

MatMaul commented Apr 3, 2023

MatMaul commented Apr 3, 2023

t3chguy commented Apr 3, 2023

Ship linux tarball with static sqlcipher #597

Ship linux tarball with static sqlcipher #597

Conversation

t3chguy commented Mar 30, 2023 • edited by github-actions bot Loading

✨ Features

t3chguy commented Mar 30, 2023

t3chguy commented Mar 30, 2023

MatMaul commented Apr 3, 2023

t3chguy commented Apr 3, 2023

MatMaul commented Apr 3, 2023

MatMaul commented Apr 3, 2023

t3chguy commented Apr 3, 2023

t3chguy commented Mar 30, 2023 •

edited by github-actions bot

Loading