Clicking any room, space, person results in "Something went wrong!" popup

[kkatz151]

Steps to reproduce

1. Start web browser, firefox, brave, etc
2. login and enter key for a previously working account
3. after viewing https://app.element.io/#/room/.. click on any room, space, or person

note: settings page can also be viewed and eddited. it is only opening he said above.

Outcome

What did you expect?

What happened instead?

Operating system

linux

Browser information

Version 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)

URL for webapp

https://app.element.io/#/room/

Application version

Element version: 1.11.25 Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes

[kkatz151]

i cant get to messsage area. but i can send what is in F12 console.log. it is saved, but i have a new question. is there anything in there security wise i need to be concerned with?
i can paste a snipit maybe:
rageshake.ts:73 Switching to room id !y.....JId:conduit.rs at event undefined
rageshake.ts:73 RVS update: !ytAj.....Id:conduit.rs null loading? false joining? false initial? true shouldPeek? true
rageshake.ts:73 newscreen room/#_discord_4496......33760:conduit.rs
rageshake.ts:73 TypeError: t.forEach is not a function
at DMRoomMap.ts:201:21

[t3chguy]

https://github.com/matrix-org/matrix-react-sdk/blob/master/src/utils/DMRoomMap.ts#L201

Looks like your m.direct event is invalid.

Could you run /devtools > Explore account data > m.direct and possibly share the content, feel free to redact the Matrix IDs

[kkatz151]

sure, but where do i type /devtools

[t3chguy]

In any room that you are in, in the box you type messages into

[kkatz151]

I guess my steps to reproduce wernt clear enough, unless i do not understand. When I click on any room. space, person, I get the popup in a web page. I never get to a room where i can enter any such text. working on a screenshot...

[t3chguy]

Well that's problematic

[t3chguy]

@kkatz151 can you open your browser console and enter JSON.stringify(mxMatrixClientPeg.matrixClient.getAccountData("m.direct").getContent(), null, 4) and paste that in here (again feel free to redact the identifiers)

[andybalaam]

Potentially related rageshakes?

https://github.com/matrix-org/element-web-rageshakes/issues/20784
https://github.com/matrix-org/element-web-rageshakes/issues/20785

[andybalaam]

Those have something like this in the logs:

2023-03-23T11:37:46.404Z E t.forEach is not a function
TypeError: t.forEach is not a function
    at https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:473358
    at Array.reduce (<anonymous>)
    at h.getRoomIds (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:473340)
    at s (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:1418538)
    at em.render (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:738691)
    at Va (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3431507)
    at qa (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3431306)
    at Ws (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3472137)
    at Ol (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3458359)
    at Dl (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3458287)
2023-03-23T11:37:46.409Z E t.forEach is not a function
TypeError: t.forEach is not a function
    at https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:473358
    at Array.reduce (<anonymous>)
    at h.getRoomIds (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:473340)
    at s (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:1418538)
    at em.render (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:738691)
    at Va (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3431507)
    at qa (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3431306)
    at Ws (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3472137)
    at Ol (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3458359)
    at Dl (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~init.js:2:3458287)
2023-03-23T11:37:46.409Z E The above error occurred while React was rendering the following components: 
    at em (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:707400)
    at div
    at div
    at div
    at _m (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:762820)
    at g (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:1173137)
    at $e (https://app.element.io/bundles/3affc09bff83ed2548f5/vendors~element-web-app.js:2:9569)

[kkatz151]

Yes I see the above @andybalaam
here is paste @t3chguy

{
  "type": "m.direct",  
  "content": {
    "@wa...irt:matrix.org": [
      "!Kg...HKW:matrix.org"
    ],
    "@cor...ren:tedomum.net": [
      "!GoC...lO:matrix.org"
    ],
    "@al...rx:matrix.org": [
      "!PeAfb...Dqj:matrix.org"
    ],
    "@kal...ot:matrix.org": [
      "!Po...ncum:matrix.org"
    ],
    "@x..b:matrix.org": [
      "!Rmc...iQ:matrix.org"
    ],
    "@gi..a:g..dra.xyz": [
      "!QvE...RAB:matrix.org"
    ],
    "@ay...a:matrix.org": [
      "!VOoRn...cMf:matrix.org"
    ],
    "@mi..e:matrix.org": [
      "!bk...MtP:matrix.org"
    ],
    "@f...6:matrix.org": [
      "!wwnk...ITj:matrix.org"
    ],
    "@mo...11:matrix.org": [
      "!kDy...BM:matrix.org"
    ],
    "@ka...olf:matrix.org": [
      "!zI...lDvp:matrix.org"
    ],
    
  }}

[t3chguy]

Looks like somewhere the m.direct content is getting set to the whole event which is worrying

[andybalaam]

Decoded trace (thanks @justjanne !)

2023-03-23T11:37:46.404Z E t.forEach is not a function
TypeError: t.forEach is not a function
    at webpack:///node_modules/matrix-react-sdk/src/utils/DMRoomMap.ts:201:20
    at Array.reduce (<anonymous>)
    at h.getRoomIds (webpack:///node_modules/matrix-react-sdk/src/utils/DMRoomMap.ts:200:48)
    at s (webpack:///node_modules/matrix-react-sdk/src/utils/room/shouldEncryptRoomWithSingle3rdPartyInvite.ts:33:28)
    at em.render (webpack:///node_modules/matrix-react-sdk/src/components/structures/RoomView.tsx:1966:93)
    at Va (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:187:187)
    at qa (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:186:172)
    at Ws (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:269:426)
    at Ol (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:250:346)
    at Dl (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:250:277)
2023-03-23T11:37:46.409Z E t.forEach is not a function
TypeError: t.forEach is not a function
    at webpack:///node_modules/matrix-react-sdk/src/utils/DMRoomMap.ts:201:20
    at Array.reduce (<anonymous>)
    at h.getRoomIds (webpack:///node_modules/matrix-react-sdk/src/utils/DMRoomMap.ts:200:48)
    at s (webpack:///node_modules/matrix-react-sdk/src/utils/room/shouldEncryptRoomWithSingle3rdPartyInvite.ts:33:28)
    at em.render (webpack:///node_modules/matrix-react-sdk/src/components/structures/RoomView.tsx:1966:93)
    at Va (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:187:187)
    at qa (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:186:172)
    at Ws (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:269:426)
    at Ol (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:250:346)
    at Dl (webpack:///node_modules/react-dom/cjs/react-dom.production.min.js:250:277)
2023-03-23T11:37:46.409Z E The above error occurred while React was rendering the following components: 
    at em (webpack:///node_modules/matrix-react-sdk/src/components/structures/RoomView.tsx:386:8)
    at div
    at div
    at div
    at _m (webpack:///node_modules/matrix-react-sdk/src/components/structures/LoggedInView.tsx:139:8)
    at g (webpack:///node_modules/matrix-react-sdk/src/components/views/elements/ErrorBoundary.tsx:38:8)
    at $e (webpack:///node_modules/matrix-react-sdk/src/components/structures/MatrixChat.tsx:244:8)

[kkatz151]

[weeman1337]

@kkatz151 thank you for providing more information.

I still have more questions:

• Is the console output the result of exactly this command: JSON.stringify(mxMatrixClientPeg.matrixClient.getAccountData("m.direct").getContent(), null, 4) ? I don't care about the … here but more about the structure.
• Did you update your account data manually? For instance via the API or dev tools?
• Do you use other Matrix clients with your account?

[andybalaam]

Currently it looks like this is a problem for one person only, so unmarking release blocker.

[kkatz151]

@weeman1337

{
    "type": "m.direct",
    "content": {
        "@w.org": [
            "!K.org"
        ],
        "@c.net": [
            "!G.org"
        ],
        "@a.org": [
            "!P.org"
        ],
        "@k.org": [
            "!P.org"
        ],
        "@x.org": [
            "!R.org"
        ],
        "@g.xyz": [
            "!Q.org"
        ],
        "@a.org": [
            "!VO.org"
        ],
        "@m.org": [
            "!b.org"
        ],
        "@f.org": [
            "!w.org"
        ],
        "@m.org": [
            "!k.org"
        ],
        "@k.org": [
            "!z.org"
        ]
    }
}

yes, I WAS using "Syphon" on the android phone
no, i havent edited anything manually

[weeman1337]

Thanks for the fast response @kkatz151 .

Your problem is caused by the m.direct account data. I will do a review of the Element Web code writing that. Additionally I am going to add an input validation.

To fix your client you can do:

• ℹ️ be careful with the following steps
• Get your account data in a single line by calling this command from your browser console JSON.stringify(mxMatrixClientPeg.matrixClient.getAccountData("m.direct").getContent())
• Store it somewhere, so that there is a backup in case of messing anything up
• Then just copy the part in "content"

For instance

{ "type": "m.direct", "content": {"@w.org": ["!K.org" ],   …    }}

Should become

{  "@w.org": [   "!K.org"   ],    …}

Validate that this is proper JSON by calling this from your browser console: JSON.parse('INSERT NEW CONTENT HERE''). Do replace INSERT NEW CONTENT HERE with the modified content from above.

Set the new content with this command mxMatrixClientPeg.matrixClient.setAccountData("m.direct", 'INSERT NEW CONTENT HERE'). Do replace INSERT NEW CONTENT HERE with the modified content from above here as well.

Then reload the page and see if it works again.

Let me know if this works for you. If you have any questions leave a comment here.

[kkatz151]

@weeman1337 Yes, all fixed. ty ty. had trouble with a bit of your instructions on where to place the single quotes, but got it figured. checked all the rooms, and people and i think its ok, I think some people disappeared. but its at least workable now. yes only 2 ppl didnt make it , but thats ok, i can deal with it later.
I also am not sure if the android app, Syphon was at fault, but i am going to uninstall it.

[t3chguy]

Looks like this is a bug in Syphon: syphon-org/syphon#632

[weeman1337]

Then lets close this one by matrix-org/matrix-react-sdk#10436 .

I did a quick check of all places writing m.direct without finding any issue there.

[kkatz151]

agreed ty all