-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTUE: Soft logout #6257
FTUE: Soft logout #6257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
The only change that would be worth investigating is similar to the deep links, we could now use AuthenticationService.shared.softLogoutCredentials
directly instead of passing parameters from the legacy app delegate up through the bridge presenter. This should help simplify the logic in the tab bar controller even more 🤞
RiotSwiftUI/Modules/Authentication/Common/Service/MatrixSDK/LoginWizard.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Authentication/SoftLogout/View/AuthenticationSoftLogoutScreen.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Authentication/SoftLogout/View/AuthenticationSoftLogoutScreen.swift
Outdated
Show resolved
Hide resolved
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BKG88T |
Yeah thanks for the suggestion, it's much more clear now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! Looks great 👌
Fixes #6181
Remaining items: