Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTUE: Soft logout #6257

Merged
merged 15 commits into from
Jun 9, 2022
Merged

FTUE: Soft logout #6257

merged 15 commits into from
Jun 9, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Jun 8, 2022

Fixes #6181

Remaining items:

  • Add confirmation for clearing data
  • Blank screen before soft logout

@ismailgulek ismailgulek requested a review from pixlwave June 8, 2022 14:42
@ismailgulek
Copy link
Contributor Author

Screenshots for some states:

matrix.org:
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-08 at 17 40 33

only SSO:
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-08 at 17 40 42

No SSO:
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-08 at 17 40 54

Fallback:
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-08 at 17 40 58

Fallback and no key backup needed:
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-08 at 17 41 07

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

The only change that would be worth investigating is similar to the deep links, we could now use AuthenticationService.shared.softLogoutCredentials directly instead of passing parameters from the legacy app delegate up through the bridge presenter. This should help simplify the logic in the tab bar controller even more 🤞

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BKG88T

@ismailgulek ismailgulek marked this pull request as ready for review June 9, 2022 12:49
@ismailgulek ismailgulek requested a review from pixlwave June 9, 2022 12:49
@ismailgulek
Copy link
Contributor Author

This is great!

The only change that would be worth investigating is similar to the deep links, we could now use AuthenticationService.shared.softLogoutCredentials directly instead of passing parameters from the legacy app delegate up through the bridge presenter. This should help simplify the logic in the tab bar controller even more 🤞

Yeah thanks for the suggestion, it's much more clear now

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Looks great 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication: Add support for Soft logout in new flow
2 participants