Fix unresponsive soft-logout in the legacy flow. #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delegate logic to the OnboardingCoordinator like the new flow does. - Reset the credentials on every presentation of authVC. - Make sure not to set the credentials after deleting the data.
pixlwave
commented
Jun 21, 2022
Comment on lines
268
to
274
| self.showClearAllDataConfirmation { | ||
| MXLog.debug("[OnboardingCoordinator] showLegacyAuthenticationScreen: Clear all data after soft logout") | ||
| self.authenticationService.reset() | ||
| self.authenticationFinished = false | ||
| self.cancelAuthentication(flow: .login) | ||
| AppDelegate.theDelegate().logoutSendingRequestServer(true, completion: nil) | ||
| } |
There was a problem hiding this comment.
This is the same code as used in the callback from the new flow. @ismailgulek, I was wondering if it would make sense to remove the completion closure and place that code directly in the method to avoid duplication. WDYT?
There was a problem hiding this comment.
Yeah makes sense to me 👍
ismailgulek
reviewed
Jun 21, 2022
| @@ -606,9 +614,9 @@ final class OnboardingCoordinator: NSObject, OnboardingCoordinatorProtocol { | |||
| message: VectorL10n.authSoftlogoutClearDataSignOutMsg, | |||
| preferredStyle: .alert) | |||
| alertController.addAction(UIAlertAction(title: VectorL10n.cancel, style: .cancel, handler: nil)) | |||
| alertController.addAction(UIAlertAction(title: VectorL10n.authSoftlogoutClearDataSignOut, style: .default, handler: { action in | |||
| alertController.addAction(UIAlertAction(title: VectorL10n.authSoftlogoutClearDataSignOut, style: .destructive) { action in | |||
|
Kudos, SonarCloud Quality Gate passed!
|
stefanceriu
pushed a commit
that referenced
this pull request
Jun 28, 2022
- Delegate logic to the OnboardingCoordinator like the new flow does. - Reset the credentials on every presentation of authVC. - Make sure not to set the credentials after deleting the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5881 (the crash was already fixed as part of #6257) by making sure that splash screen/use case screen is presented after choosing to delete all data when using the old auth flow. This is done by
OnboardingCoordinatorlike the new flow does.