Fix blank room screen #6565
Fix blank room screen #6565
Conversation
ismailgulek
force-pushed
the
ismail/5932_blank_room_screen
branch
from
28c31ad
to
98338fd
Compare
|
|
||
| // Add an accessory view to the text view in order to retrieve keyboard view. | ||
| inputAccessoryView = [[UIView alloc] initWithFrame:CGRectZero]; | ||
| self.textView.inputAccessoryView = inputAccessoryView; |
There was a problem hiding this comment.
Have you checked against #5042 to see if this change causes a regression on iPhone?
There was a problem hiding this comment.
Yeah it caused, i've reverted that (including a name change to avoid confusion). I've fixed the issue 3 by updating the constraints of table view in the room screen.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ceBgea |
Codecov Report
@@ Coverage Diff @@
## develop #6565 +/- ##
===========================================
+ Coverage 6.28% 6.29% +0.01%
===========================================
Files 1458 1458
Lines 153924 153931 +7
Branches 61867 61875 +8
===========================================
+ Hits 9668 9692 +24
+ Misses 143850 143831 -19
- Partials 406 408 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Kudos, SonarCloud Quality Gate passed!
|
I couldn't reproduce the issue by playing with network connection. I could see a blank screen but also a syncing spinner was there.
The issue seen on iPad was due to an unnecessary
inputAccessoryViewon message text view. Somehow the table view was insetted wrongly (so that all the content to be out of screen).This PR also addresses some suspicious
UITableViewerrors i saw in logs.There may be other cases for the issue we're not aware of yet.
Element[4045:46257] [Assert] Attempted to access the table view's visibleCells while they were in the process of being updated, which is not allowed. Make a symbolic breakpoint at UITableViewAlertForVisibleCellsAccessDuringUpdate to catch this in the debugger and see what caused this to occur. Perhaps you are trying to ask the table view for the visible cells from inside a table view callback about a specific row? Table view: <UITableView: 0x7fc1d0150000; frame = (0 0; 428 777); autoresize = RM+BM; gestureRecognizers = <NSArray: 0x6000010835a0>; layer = <CALayer: 0x600001d853c0>; contentOffset: {0, 0}; contentSize: {428, 1998.6666641235352}; adjustedContentInset: {0, 0, 34, 0}; dataSource: <RoomDataSource: 0x7fc1c72d13e0>>Element[4288:55918] [TableView] Warning once only: UITableView was told to layout its visible cells and other contents without being in the view hierarchy (the table view or one of its superviews has not been added to a window). This may cause bugs by forcing views inside the table view to load and perform layout without accurate information (e.g. table view bounds, trait collection, layout margins, safe area insets, etc), and will also cause unnecessary performance overhead due to extra layout passes. Make a symbolic breakpoint at UITableViewAlertForLayoutOutsideViewHierarchy to catch this in the debugger and see what caused this to occur, so you can avoid this action altogether if possible, or defer it until the table view has been added to a window. Table view: <UITableView: 0x7fc927027a00; frame = (0 0; 428 868); hidden = YES; autoresize = RM+BM; gestureRecognizers = <NSArray: 0x6000018f4360>; layer = <CALayer: 0x6000016d5060>; contentOffset: {0, 0}; contentSize: {428, 0}; adjustedContentInset: {0, 0, 0, 0}; dataSource: (null)>iPad issue after orientation changes (reported at https://matrix.to/#/!NMoyFpQxIVYaQIfQHG:matrix.org/$Pf9_zjq5XrNPmWCI57DjdYnFcffH3NcS0iNHJKvx6rY?via=matrix.org&via=element.io&via=one.ems.host)
Fixes #5932