Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix.to permalinks should be pillified somehow #281

Closed
ara4n opened this issue Aug 1, 2019 · 7 comments
Closed

matrix.to permalinks should be pillified somehow #281

ara4n opened this issue Aug 1, 2019 · 7 comments
Assignees
Labels
A-Composer A-Matrix.to A-Pills A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Team: Delight X-Needs-Product More input needed from the Product team Z-AccountResurrection Delight - cycle

Comments

@ara4n
Copy link
Member

ara4n commented Aug 1, 2019

to make them look less fugly and provide more useful info (avatar, room name, event sender, date, etc)

@anoadragon453
Copy link
Member

Ideally you should still be able to right-click them and get the actual link to send to non-matrix places.

@bwindels
Copy link

bwindels commented Oct 19, 2020

This seems to be currently implemented but I find it somewhat confusing as it looks like a link is just to a room when in fact it goes to a specific event. Also, if it is wrapped in a markdown link, the link text is ignored and your sentence doesn't make sense anymore...

@jryans
Copy link

jryans commented Jan 26, 2021

This seems to be currently implemented but I find it somewhat confusing as it looks like a link is just to a room when in fact it goes to a specific event. Also, if it is wrapped in a markdown link, the link text is ignored and your sentence doesn't make sense anymore...

Created element-hq/element-web#16285 for this variant.

@ara4n
Copy link
Member Author

ara4n commented May 22, 2022

This needs product input. Considerations are:

  • Room (and space) permalinks should be shown as room pillls (which they are already)
  • User permalinks should be shown as user pills (which they are already)
  • It's less clear what to do with message permalinks:
    • Show a pill which includes a timestamp and a username and the (beginning of) the message?
    • Show a url preview?
    • Show a link to the message as if it were a reply?

For this message permalinks to work in rooms which you're not a member of, then /event or /context need to support peeked rooms (which one would probably get for free with https://github.com/matrix-org/matrix-spec-proposals/pull/2753/files#r878848729).

@t3chguy t3chguy transferred this issue from element-hq/element-web May 22, 2022
@t3chguy
Copy link
Member

t3chguy commented May 22, 2022

This should be considered in the context of all platforms, not just web, as permalinks right now are super ugly and the matrix.to url preview rather useless

image

@niquewoodhouse
Copy link

I put some pill designs in Figma. We could use the message type to give a richer experience to timeline readers.

image

@daniellekirkwood
Copy link
Contributor

We were tracking the team's work on this in the epic linked here

Therefore, I believe this issue is now complete... closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Matrix.to A-Pills A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Team: Delight X-Needs-Product More input needed from the Product team Z-AccountResurrection Delight - cycle
Projects
None yet
Development

No branches or pull requests

9 participants