Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pills from event permalinks with text #16285

Closed
jryans opened this issue Jan 26, 2021 · 1 comment
Closed

Remove pills from event permalinks with text #16285

jryans opened this issue Jan 26, 2021 · 1 comment
Assignees
@jryans
Labels
A-Matrix.to A-Pills A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 26, 2021

(Originally mentioned in element-hq/element-meta#281)

Element Web has a fairly bad presentation of links to event permalinks with link text (e.g. via Markdown).

For example, if you write something like:

Read [this](https://matrix.to/#/!ZxbRYPQXDXKGmDnJNg:matrix.org/$16085560162aNpaH:matrix.org?via=matrix.org) message

...Element Web currently shows:

image

so the word "this" is completely hidden and the sentence becomes nonsensical.

To resolve this, we should stop pillifying event permalinks with text, which would also match Element mobile platforms.
@jryans jryans added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline defect A-Matrix.to labels Jan 26, 2021
@jryans jryans self-assigned this Jan 26, 2021
@jryans jryans mentioned this issue Jan 26, 2021
Closed
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 26, 2021
@jryans
Remove pills from event permalinks with text
ce4095e 
This removes pills from event permalinks since they hide the text associated
with the link, which can cause nonsensical messages since words have been
removed.

Fixes element-hq/element-web#16285
@jryans jryans mentioned this issue Jan 26, 2021
Merged
@jryans
Copy link
Collaborator Author

jryans commented Jan 26, 2021

A bit more discussion in #15159, so let's use that as the canonical issue.

@jryans jryans closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Matrix.to A-Pills A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @aaronraimist