Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the IS optional during discovery #11102

Closed
jryans opened this issue Oct 9, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3588
Closed

Make the IS optional during discovery #11102

jryans opened this issue Oct 9, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3588
Assignees
@jryans
Labels
A-Identity-Server Privacy T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented Oct 9, 2019 •
edited
Loading

This would implement matrix-org/matrix-spec-proposals#2284.

At the moment, if the HS .well-known includes an IS but it is invalid, this is a hard error. Following the above MSC would allow the user to continue.
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 1, 2019
@jryans
Relax identity server discovery checks to FAIL_PROMPT
9680618 
As discussed in MSC2284, this relaxes the identity server discovery to a
`FAIL_PROMPT` state so that clients can choose to warn and continue.

Part of element-hq/element-web#11102
@jryans jryans self-assigned this Nov 1, 2019
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 1, 2019
@jryans
Relax identity server discovery checks to FAIL_PROMPT
45836b8 
As discussed in MSC2284, this relaxes the identity server discovery to a
`FAIL_PROMPT` state so that clients can choose to warn and continue.

Part of element-hq/element-web#11102
Implements matrix-org/matrix-spec-proposals#2284
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 1, 2019
@jryans
Relax identity server discovery checks to FAIL_PROMPT
e8fd049 
As discussed in MSC2284, this relaxes the identity server discovery to a
`FAIL_PROMPT` state so that clients can choose to warn and continue.

Part of element-hq/element-web#11102
Implements matrix-org/matrix-spec-proposals#2284
@jryans jryans mentioned this issue Nov 1, 2019
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 1, 2019
@jryans
Relax identity server discovery error handling
446e21c 
If discovery results in a warning for the identity server (as in can't be found
or is malformed), this allows you to continue signing in and shows the warning
above the form.

Fixes element-hq/element-web#11102
@jryans jryans mentioned this issue Nov 1, 2019
Merged
@jryans
Copy link
Collaborator Author

jryans commented Nov 1, 2019

This is blocked on the MSC progressing. We aren't able to use the unstable feature process for .well-known changes.

@jryans
Copy link
Collaborator Author

jryans commented Nov 13, 2019

FCP has now begun on the MSC. It should be safe to merge this once FCP has ended.

@jryans jryans removed the X-Blocked label Nov 18, 2019
@jryans
Copy link
Collaborator Author

jryans commented Nov 18, 2019

It's now safe to proceed here.

turt2live pushed a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 26, 2019
@jryans @turt2live
Relax identity server discovery checks to FAIL_PROMPT
d2803d5 
As discussed in MSC2284, this relaxes the identity server discovery to a
`FAIL_PROMPT` state so that clients can choose to warn and continue.

Part of element-hq/element-web#11102
Implements matrix-org/matrix-spec-proposals#2284
turt2live pushed a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 26, 2019
@jryans @turt2live
Relax identity server discovery checks to FAIL_PROMPT
6b38868 
As discussed in MSC2284, this relaxes the identity server discovery to a
`FAIL_PROMPT` state so that clients can choose to warn and continue.

Part of element-hq/element-web#11102
Implements matrix-org/matrix-spec-proposals#2284
This was referenced Aug 31, 2020
Closed
Merged
su-ex added a commit to SchildiChat/element-web that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v1.11.35' into sc
d789c9a 
* Remove `feature_favourite_messages` as it is has been abandoned for now ([\#11097](matrix-org/matrix-react-sdk#11097)). Fixes element-hq#25555.
* Don't setup keys on login when encryption is force disabled ([\element-hq#11125](matrix-org/matrix-react-sdk#11125)). Contributed by @kerryarchibald.
* OIDC: attempt dynamic client registration ([\element-hq#11074](matrix-org/matrix-react-sdk#11074)). Fixes element-hq#25468 and element-hq#25467. Contributed by @kerryarchibald.
* OIDC: Check static client registration and add login flow ([\element-hq#11088](matrix-org/matrix-react-sdk#11088)). Fixes element-hq#25467. Contributed by @kerryarchibald.
* Improve message body output from plain text editor ([\element-hq#11124](matrix-org/matrix-react-sdk#11124)). Contributed by @alunturner.
* Disable encryption toggle in room settings when force disabled ([\element-hq#11122](matrix-org/matrix-react-sdk#11122)). Contributed by @kerryarchibald.
* Add .well-known config option to force disable encryption on room creation ([\element-hq#11120](matrix-org/matrix-react-sdk#11120)). Contributed by @kerryarchibald.
* Handle permalinks in room topic ([\element-hq#11115](matrix-org/matrix-react-sdk#11115)). Fixes element-hq#23395.
* Add at room avatar for RTE ([\element-hq#11106](matrix-org/matrix-react-sdk#11106)). Contributed by @alunturner.
* Remove new room breadcrumbs ([\element-hq#11104](matrix-org/matrix-react-sdk#11104)).
* Update rich text editor dependency and associated changes ([\element-hq#11098](matrix-org/matrix-react-sdk#11098)). Contributed by @alunturner.
* Implement new model, hooks and reconcilation code for new GYU notification settings ([\element-hq#11089](matrix-org/matrix-react-sdk#11089)). Contributed by @justjanne.
* Allow maintaining a different right panel width for thread panels ([\element-hq#11064](matrix-org/matrix-react-sdk#11064)). Fixes element-hq#25487.
* Make AppPermission pane scrollable ([\element-hq#10954](matrix-org/matrix-react-sdk#10954)). Fixes element-hq#25438 and element-hq#25511. Contributed by @luixxiul.
* Integrate compound design tokens ([\element-hq#11091](matrix-org/matrix-react-sdk#11091)). Fixes vector-im/internal-planning#450.
* Don't warn about the effects of redacting state events when redacting non-state-events ([\element-hq#11071](matrix-org/matrix-react-sdk#11071)). Fixes element-hq#8478.
* Allow specifying help URLs in config.json ([\element-hq#11070](matrix-org/matrix-react-sdk#11070)). Fixes element-hq#15268.
* Fix error when generating error for polling for updates ([\element-hq#25609](element-hq#25609)).
* Fix spurious notifications on non-live events ([\element-hq#11133](matrix-org/matrix-react-sdk#11133)). Fixes element-hq#24336.
* Prevent auto-translation within composer ([\#11114](matrix-org/matrix-react-sdk#11114)). Fixes element-hq#25624.
* Fix caret jump when backspacing into empty line at beginning of editor ([\#11128](matrix-org/matrix-react-sdk#11128)). Fixes element-hq#22335.
* Fix server picker not allowing you to switch from custom to default ([\element-hq#11127](matrix-org/matrix-react-sdk#11127)). Fixes element-hq#25650.
* Consider the unthreaded read receipt for Unread dot state ([\element-hq#11117](matrix-org/matrix-react-sdk#11117)). Fixes element-hq#24229.
* Increase RTE resilience ([\element-hq#11111](matrix-org/matrix-react-sdk#11111)). Fixes element-hq#25277. Contributed by @alunturner.
* Fix RoomView ignoring alias lookup errors due to them not knowing the roomId ([\element-hq#11099](matrix-org/matrix-react-sdk#11099)). Fixes element-hq#24783 and element-hq#25562.
* Fix style inconsistencies on SecureBackupPanel ([\element-hq#11102](matrix-org/matrix-react-sdk#11102)). Fixes element-hq#25615. Contributed by @luixxiul.
* Remove unknown MXIDs from invite suggestions ([\element-hq#11055](matrix-org/matrix-react-sdk#11055)). Fixes element-hq#25446.
* Reduce volume of ring sounds to normalised levels ([\element-hq#9143](matrix-org/matrix-react-sdk#9143)). Contributed by @JMoVS.
* Fix slash commands not being enabled in certain cases ([\element-hq#11090](matrix-org/matrix-react-sdk#11090)). Fixes element-hq#25572.
* Prevent escape in threads from sending focus to main timeline composer ([\element-hq#11061](matrix-org/matrix-react-sdk#11061)). Fixes element-hq#23397.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server Privacy T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax identity server discovery error handling matrix-org/matrix-react-sdk
1 participant
@jryans