Relax identity server discovery error handling #3588
Conversation
If discovery results in a warning for the identity server (as in can't be found or is malformed), this allows you to continue signing in and shows the warning above the form. Fixes element-hq/element-web#11102
| @@ -33,6 +34,8 @@ export class ValidatedServerConfig { | |||
| isUrl: string; | |||
|
|
|||
| isDefault: boolean; | |||
|
|
|||
| warning: string; | |||
There was a problem hiding this comment.
ideally we don't put state flags here - this is just a configuration blob, not an object meant to carry state to other components.
hsNameIsDifferent arguably shouldn't be here either, but its role is slightly different.
There was a problem hiding this comment.
I agree it's not great, but I also don't want throw and change control flow of callers... Should validation methods return multiple objects then to contain the warning...?
There was a problem hiding this comment.
I think this is fine for now, just highlighting that the original design of this didn't really anticipate this kind of flag being required.
| // rewrite homeserver error if we don't care about problems | ||
| if (syntaxOnly) { | ||
| hsResult.error = AutoDiscovery.ERROR_INVALID_IDENTITY_SERVER; | ||
| // rewrite homeserver error since we don't care about problems |
There was a problem hiding this comment.
we do care about problems - this syntaxOnly flag is used during app startup.
There was a problem hiding this comment.
I don't follow your comment here... The current change intends that we only reach this point if we got FAIL_PROMPT. If so, we want to record a warning with or without syntaxOnly mode.
There was a problem hiding this comment.
I think you're right, but I am concerned that the app won't load if there's a warning. If the app loads fine with no identity server (or a dead identity server) while the user is logged in, then this is fine.
There was a problem hiding this comment.
Yes, the app loads with a dead identity server while logged in.
If discovery results in a warning for the identity server (as in can't be found
or is malformed), this allows you to continue signing in and shows the warning
above the form.
Fixes element-hq/element-web#11102