-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it crystal clear that you should not run Vector on the same domain as a HS #1977
Comments
Do we also want to add |
I'm interested why you shouldn't do that |
For the same reasons as https://developer.github.com/changes/2014-04-25-user-content-security. We'll ship an updated synapse very shortly (possibly today) with Erik's fix mentioned above to mitigate the risk. |
synapse 0.17.1 shipped with a mitigation for this. Meanwhile I've pushed matrix-org/synapse@907486e and efc5462 to recommend that people put HSes on their own domain if at all possible. |
This was also mitigated a bit in vector in d3eccc1 ftr. |
Is this still something to be aware of: I run Vector and Synapse on the same server. Both proxied through Nginx. Vector on |
synapse 0.17.1 makes this much less of a concern, hence not pushing this issue. in general it's good practice to host on separate vhosts anyway, as you are doing. no need for physically separate hosts. |
What is best practice? It's not clear to me. “Much less of a concern” doesn't sound like not a concern at all. |
You are sharing cookies if you share a common root domain, so form submission logic is wacky. But as long as long as the sub-domains are different, the SOP is enforced correctly. |
Best practice is still to run Riot on a separate domain to the homeserver for good hygiene. However, we are not aware of any current attacks caused by sharing domain.
We don't use cookies anywhere so form submission attacks aren't a major concern.
|
element-hq/element-web#1977 --> element-hq/element-web#1977 And mention of Vector as a client replaced with Riot.
Hello, In this thread, you mention (from what I understand) that having Riot and Synapse served in matrix.domain.tld and riot.domain.tld doesn't bring security issues. Also, it's mentioned that it's better to run Synapse and Riot in different machines (wether physical or virtual). Thank you :) |
I am also interested whether this scenario is okay or not from a security standpoint. The whole domain/XSS part of the web is not exactly my strong suit, so I would also appreciate if you clarified this. Thank you :) |
Good evening, |
Please ask support questions like this in Matrix rooms like #element-web:matrix.org. |
And instead your media repo at least should be on a different domain.
The text was updated successfully, but these errors were encountered: