Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Replace mentions of Vector with Riot #4210

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

axelsimon
Copy link
Contributor

element-hq/element-web#1977 --> element-hq/element-web#1977
And mention of Vector as a client replaced with Riot.

element-hq/element-web#1977 --> element-hq/element-web#1977
And mention of Vector as a client replaced with Riot.
@neilisfragile
Copy link
Contributor

Hi @axelsimon thanks for the PR, I know it's a pain but can you take a look at https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst

I need

  • your sign off and
  • an entry in Changes.d/ and please credit yourself!
  • base off develop branch, not master

@axelsimon
Copy link
Contributor Author

axelsimon commented Nov 20, 2018

Understood, no problem.

Signed-off-by: axel simon axelsimon@axelsimon.net

@axelsimon axelsimon changed the base branch from master to develop November 20, 2018 16:31
@axelsimon
Copy link
Contributor Author

Right, I've changed the base branch from master to develop and signed off. I also created a PRnumber.type file in changelog.d in my axelsimon-patch-1 branch, but I'm not sure that's being picked up by this PR (although Github tells me "Add more commits by pushing to the patch-1 branch on axelsimon/synapse")

I think I'm missing something, any clues would be appreciated :)

@turt2live
Copy link
Member

Your branch would be patch-1 not axelsimon-patch-1.

@richvdh
Copy link
Member

richvdh commented Nov 20, 2018

(and you'd need to remember to git push your changes)

@richvdh
Copy link
Member

richvdh commented Dec 4, 2018

I think we can take this without a newsfile.

@richvdh richvdh merged commit dd27e47 into matrix-org:develop Dec 4, 2018
@axelsimon
Copy link
Contributor Author

Thanks Rich!

@axelsimon axelsimon deleted the patch-1 branch December 4, 2018 17:12
@eMPee584
Copy link

…by the way, who on EARTH came up with that violent name, and how did the group process converge into choosing it?!
seriously, vector is a much more appealing name, especially in academics. WTH.

@ara4n
Copy link
Member

ara4n commented Mar 28, 2019

i’d argue the name (which can refer as much to a riot of colour, as to a riot of violence) is less violent than your comment.

@matrix-org matrix-org locked and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants