After reloading, clicking a space bounces around to the wrong space

[turt2live]

The steps to reproduce this are difficult, but extremely common in my daily usage:

1. Visit a room within a space which is included in another space. In my case, the Maunium space's Telegram bridge room
2. Visit a different space/room combination to assist in the bug
3. Reload/restart element
4. Click on the space from step 1 - this should bounce you into the space, then out of it again when the room change is detected
5. Repeat for all available spaces. Does not occur after the space has been visited once.

For added context, the t2bot.io space has the Telegram bridge room also listed, and the t2bot.io room is higher on the panel than the Maunium space. I suspect what's happening is a store somewhere is detecting a room change (something -> telegram bridge) and forgetting/ignoring that a space change is also happening and so is trying to find the most relevant space to switch the user to.

This is additionally problematic when trying to visit community-specific spaces that get overruled by the Matrix Community, Core, and Corp spaces as they are massive and have all sorts of rooms.

[HarHarLinks]

I believe I have the same issue. It feels to me that often when switching to a space, it'll jump back to matrix community space on it's own, but may also to others. Mostly feels like an issue of overlap between matrix and element spaces. It'll always happen the first couple times after reloading/starting element, but then stop happening, very much as described above.

jumpy_spaces.mp4

Element Nightly version: 2022011001 from aur/element-desktop-nightly-bin
Olm version: 3.2.8

[t3chguy]

I cannot reproduce this on a test account

Screen.Recording.2022-01-11.at.11.09.35.mov

[t3chguy]

Only think of is a weird interplay between mx_last_room_id and mx_active_space + mx_space_context_ - will try to clean that up a little nvm - mx_last_room_id doesn't look to be playing any part here, could really do with solid repro steps on a bare account. I haven't incidentally seen it on my real account whatsoever.

[dbkr]

This is marked as a release blocker, but it's not looking like it will be a trivial fix, so I'm going to do the RC anyway. We can decide if we need to delay the release to fix this.

Do we know when it regressed?

[SimonBrandner]

I've been running into this as well

This seems to be a race condition between https://github.com/matrix-org/matrix-react-sdk/blob/f179b7c3a846d56cf5bf932d73ad80c8c0b398c3/src/stores/spaces/SpaceStore.ts#L766 (called by https://github.com/matrix-org/matrix-react-sdk/blob/f179b7c3a846d56cf5bf932d73ad80c8c0b398c3/src/stores/spaces/SpaceStore.ts#L606) and https://github.com/matrix-org/matrix-react-sdk/blob/f179b7c3a846d56cf5bf932d73ad80c8c0b398c3/src/stores/spaces/SpaceStore.ts#L198 - setActiveSpace() seems to cause RoomState.members events to be emitted which then cause a space switch in switchSpaceIfNeeded, since setActiveSpace() didn't manage to context-switch before the RoomState.members events were fired

I am not exactly sure how to fix this atm... @t3chguy, does this make sense to you? Do you have any ideas for a fix?

[turt2live]

Bumping frequency of this because it's hitting a lot more people more often now.

[Winterhuman]

I'm getting this issue as well, but, the way it's happening is different for me:

1. Start the client for the first time (not minimised in the background).
2. Set it up so when Element starts it will be in the Home space or any other space on the sidebar except the space this issue is affected by (in my case, the IPFS space always bounces and no other space does)
3. Click on the afflicted space and see it quickly highlight and de-highlight the space (Bounce).
4. Restart the client and notice it now starts with Element showing a room within the afflicted space despite the fact that this space wasn't being shown before, possibly implying it thought it was showing the user that space even though the bounce occured.

Of note is that:

• All the rooms in the IPFS space are not present in any of the other spaces I'm joined to.
• But, the Libp2p room in the ipfs-space is also within a separate space called libp2p-space, the Libp2p space itself is not in the IPFS space (or at least it's not shown there, perhaps enabling subspaces will show it), and I'm not joined to libp2p-space nor is it within any of my other spaces.