Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update highlight.js usage in-code #22233

Closed
turt2live opened this issue May 17, 2022 · 6 comments · Fixed by matrix-org/matrix-react-sdk#9923
Closed

Update highlight.js usage in-code #22233

turt2live opened this issue May 17, 2022 · 6 comments · Fixed by matrix-org/matrix-react-sdk#9923
Labels
good first issue Good for newcomers T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

from the console:

Deprecated as of 10.7.0. highlight(lang, code, ...args) has been deprecated.
Deprecated as of 10.7.0. Please use highlight(code, options) instead.
https://github.com/highlightjs/highlight.js/issues/2277
@turt2live turt2live added T-Task Tasks for the team like planning Help Wanted Extra attention is needed good first issue Good for newcomers labels May 17, 2022
@MadLittleMods MadLittleMods added Dependencies Pull requests that update a dependency file and removed Dependencies Pull requests that update a dependency file labels May 18, 2022
@justjanne justjanne mentioned this issue Jan 19, 2023
Merged
2 tasks
@SAGARGAUD01
Copy link

Hello,
I have fixed this issue dear admin.

@weeman1337 weeman1337 mentioned this issue Jan 23, 2023
Closed
@mustafa-kapadia1483 mustafa-kapadia1483 mentioned this issue Jan 25, 2023
Closed
2 tasks
@dbkr
Copy link
Member

dbkr commented Jan 27, 2023

The above PR will fix this issue once merged: we don't need any more PRs for it.

@andybalaam andybalaam removed the Help Wanted Extra attention is needed label Jan 27, 2023
@Amit-Morade
Copy link

Is this issue still open?

@weeman1337
Copy link
Contributor

Is this issue still open?

Yes. But there already is also a pull request for it matrix-org/matrix-react-sdk#9989

t3chguy pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 31, 2023
@iharnoor
Migrate highlight.js API call in TextualBody (#9923)
97f6431 
Co-authored-by: Michael Weimann <michaelw@matrix.org>
Fixes element-hq/element-web#22233
@germain-gg germain-gg mentioned this issue Feb 3, 2023
Closed
3 tasks
@BamaCharanChhandogi
Copy link

hey i take up this issue.

@weeman1337
Copy link
Contributor

hey i take up this issue.

This issue has already been solved.

@kerryarchibald kerryarchibald mentioned this issue Mar 12, 2023
Closed
2 tasks
@luixxiul luixxiul mentioned this issue May 4, 2023
Closed
1 task
@weeman1337 weeman1337 mentioned this issue Sep 18, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
8 participants
@andybalaam @MadLittleMods @dbkr @turt2live @weeman1337 @Amit-Morade @BamaCharanChhandogi @SAGARGAUD01