Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Migrate highlight.js API call in TextualBody #9923

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Migrate highlight.js API call in TextualBody #9923

merged 2 commits into from
Jan 31, 2023

Conversation

iharnoor
Copy link
Contributor

@iharnoor iharnoor commented Jan 17, 2023 •
edited by github-actions bot
Loading

Type: Task
Fixes: element-hq/element-web#22233

Checklist

  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@iharnoor iharnoor requested a review from a team as a code owner January 17, 2023 15:28
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 17, 2023
@justjanne justjanne added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 19, 2023
This was referenced Jan 23, 2023
Closed
Closed
Closed
Closed
Closed
@weeman1337 weeman1337 changed the title #22233 Issue: Update TextualBody.tsx Migrate highlight.js API call in TextualBody Jan 23, 2023
This was referenced Jan 23, 2023
Closed
Closed
Closed
@florianduros
Copy link
Contributor

Hello,

First of all, thank you for the PR.
Can you fix the Static Analysis / Typescript Strict Error Checker (--strict --noImplicitAny) error ?

@andybalaam andybalaam mentioned this pull request Jan 27, 2023
Closed
2 tasks
This was referenced Jan 30, 2023
Closed
Closed
Closed
Closed
t3chguy
t3chguy approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, thanks!

This was referenced Jan 30, 2023
Closed
Closed
@t3chguy t3chguy merged commit 97f6431 into matrix-org:develop Jan 31, 2023
@kerryarchibald kerryarchibald mentioned this pull request Mar 12, 2023
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update highlight.js usage in-code
5 participants
@iharnoor @florianduros @t3chguy @justjanne @weeman1337