Loading spinner when changing between existing rooms

[t3chguy]

Steps to reproduce

Recent regression on Nightly

change rooms, observe spinner where there shouldn't be one

Outcome

What did you expect?

No jarring spinner given this is a room which is entirely already in memory

What happened instead?

Go jarring spinner

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

[t3chguy]

v3.62.0 good
dec72c7 bad

[dbkr]

I've just looked at the requests when this happens and it's a call to the native/virtual lookup endpoint, so matrix-org/matrix-react-sdk#9626 is a likely candidate.

[t3chguy]

having landed 4 days ago that lines up

[t3chguy]

git bisect confirms that PR is the cause - regressed by matrix-org/matrix-react-sdk#9626

t3chguy@Michael-t3chguy-MBP ~/W/matrix-react-sdk ((33dfa14b…)|BISECTING)> git bisect good
Bisecting: 11 revisions left to test after this (roughly 4 steps)
[0f17728aa1b9f4d9d5176364d6c8586176989203] Merge branch 'develop' into feat/emoji-picker-rich-text-mode
t3chguy@Michael-t3chguy-MBP ~/W/matrix-react-sdk ((0f17728a…)|BISECTING)> git bisect good
Bisecting: 5 revisions left to test after this (roughly 3 steps)
[888e69f39ae7f0ff4fa88200f8b89398c24742bd] Device manage - handle sessions that don't support encryption (#9717)
t3chguy@Michael-t3chguy-MBP ~/W/matrix-react-sdk ((888e69f3…)|BISECTING)> git bisect bad
Bisecting: 2 revisions left to test after this (roughly 2 steps)
[95ac957fa433263c550a4efecd996b0b2d77aa24] add-privileged-users-in-room (#9596)
t3chguy@Michael-t3chguy-MBP ~/W/matrix-react-sdk ((95ac957f…)|BISECTING)> git bisect good
Bisecting: 0 revisions left to test after this (roughly 1 step)
[6150b86421600750dec24e207d314b2bd52b30fa] Overlay virtual room call events into main timeline (#9626)
t3chguy@Michael-t3chguy-MBP ~/W/matrix-react-sdk ((6150b864…)|BISECTING)> git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[1b6d753cfe71002024b5641b1e0a371458669466] Add voice broadcast device selection tooltip (#9726)
t3chguy@Michael-t3chguy-MBP ~/W/matrix-react-sdk ((1b6d753c…)|BISECTING)> git bisect good
6150b86421600750dec24e207d314b2bd52b30fa is the first bad commit
commit 6150b86421600750dec24e207d314b2bd52b30fa
Author: Kerry <kerrya@element.io>
Date:   Fri Dec 9 10:37:25 2022 +1300

    Overlay virtual room call events into main timeline (#9626)
    
    * super WIP POC for merging virtual room events into main timeline
    
    * remove some debugs
    
    * c
    
    * add some todos
    
    * remove hardcoded fake virtual user
    
    * insert overlay events into main timeline without resorting main tl events
    
    * remove more debugs
    
    * add extra tick to roomview tests
    
    * RoomView test case for virtual room
    
    * test case for merged timeline
    
    * make overlay event filter generic
    
    * remove TODOs from LegacyCallEventGrouper
    
    * tidy comments
    
    * remove some newlines
    
    * test timelinepanel room timeline event handling
    
    * use newState.roomId
    
    * fix strict errors in RoomView
    
    * fix strict errors in TimelinePanel
    
    * add type
    
    * pr tweaks
    
    * strict errors
    
    * more strict fix
    
    * strict error whackamole
    
    * update ROomView tests to use rtl

 src/VoipUserMapper.ts                              |   2 +-
 .../structures/LegacyCallEventGrouper.ts           |   7 +-
 src/components/structures/RoomView.tsx             |  19 +-
 src/components/structures/TimelinePanel.tsx        | 130 ++--
 test/components/structures/RoomView-test.tsx       | 119 ++-
 test/components/structures/TimelinePanel-test.tsx  | 162 +++-
 .../__snapshots__/RoomView-test.tsx.snap           | 823 ++++++++++++++++++++-
 7 files changed, 1174 insertions(+), 88 deletions(-)