Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect message scaling for verification request when information side panel is opened #24304

Closed
eNkKVS4HxHc9jaq opened this issue Jan 23, 2023 · 10 comments · Fixed by matrix-org/matrix-react-sdk#11793
Closed

Incorrect message scaling for verification request when information side panel is opened #24304

eNkKVS4HxHc9jaq opened this issue Jan 23, 2023 · 10 comments · Fixed by matrix-org/matrix-react-sdk#11793
Labels
A-Appearance A-E2EE-SAS-Verification A-Right-Panel good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@eNkKVS4HxHc9jaq
Copy link

eNkKVS4HxHc9jaq commented Jan 23, 2023 •
edited
Loading

Steps to reproduce

  1. Where are you starting? What can you see?
    I'm in a chat and the other user sent me a verification request. On the desktop version of the client, when opening the information from the Info icon, the message is scaled to an unreadable state when aligned vertically in a single column.
  2. What do you click?
    The Info icon for the side panel.
  3. More steps…

Outcome

What did you expect?

The message to normally be scaled.

What happened instead?

The message was scaled in a single vertical column to become unreadable when the side panel was open.

Operating system

Windows

Application version

Element version: 1.11.20 Olm version: 3.2.12

How did you install the app?

https://element.io/get-started
Capture

Homeserver

matrix.org

Will you send logs?

No
@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE-SAS-Verification A-Right-Panel A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers labels Jan 24, 2023
@github-actions github-actions bot added Help Wanted Extra attention is needed labels Jan 24, 2023
@KartikSingh023
Copy link

Can someone please elaborate more on this issue

@Inzamamdev
Copy link

please assign me this issue

@varunlmxd
Copy link

I am interested in taking up this issue, can you please assign me this issue?

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2023 •
edited
Loading

@varunlmxd

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

@GH-aditya
Copy link

Assign me this issue

@t3chguy
Copy link
Member

t3chguy commented Jan 31, 2023

@GH-aditya read my comment above.

@luixxiul
Copy link

luixxiul commented Mar 2, 2023

I am working on it by making the website responsive

Since hydrogen pursuits implementing mobile browser support, I think it is not great idea to try to fix this issue by making the website (UI?) responsive.

@eNkKVS4HxHc9jaq
Copy link
Author

I am working on it by making the website responsive

Since hydrogen pursuits implementing mobile browser support, I think it is not great idea to try to fix this issue by making the website (UI?) responsive.

As far as I know, Hydrogen is a completely separate lightweight version of Element Web. It is not a replacement for the standard. Making the UI responsive is the actual solution. Also I believe Hydrogen is a fork and so responsivness of the base should easily be implementable in Hydrogen as well. Furthermore making this issue worth fixing.

@luixxiul
Copy link

luixxiul commented Mar 3, 2023

My comment is directed to #24304 (comment), which seems to claim to solve the issue by making the whole UI (website) responsive, which is actually not pursued.

I agree that the issue can be fixed by making UI component responsive, and I've fixed some similar issues by doing so.

@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
@capGoblin capGoblin mentioned this issue Oct 24, 2023
Merged
1 task
gabrc52 added a commit to sipb/matrix-react-sdk that referenced this issue Nov 12, 2023
@gabrc52
Merge tag 'v3.84.0' into sipb
5fb7725 
* Knock on a ask-to-join room if a module wants to join the room when navigating to a room ([\matrix-org#11787](matrix-org#11787)). Contributed by @dhenneke.
* Element-R:  Include crypto info in sentry ([\matrix-org#11798](matrix-org#11798)). Contributed by @florianduros.
* Element-R:  Include crypto info in rageshake ([\matrix-org#11797](matrix-org#11797)). Contributed by @florianduros.
* Element-R: Add current version of the rust-sdk and vodozemac ([\matrix-org#11785](matrix-org#11785)). Contributed by @florianduros.
* Fix unfederated invite dialog ([\matrix-org#9618](matrix-org#9618)). Fixes element-hq/element-meta#1466 and element-hq/element-web#22102. Contributed by @owi92.
* New right panel visual language ([\matrix-org#11664](matrix-org#11664)).
* OIDC: add friendly errors ([\matrix-org#11184](matrix-org#11184)). Fixes element-hq/element-web#25665. Contributed by @kerryarchibald.
* Fix rightpanel hiding scrollbar ([\matrix-org#11831](matrix-org#11831)). Contributed by @kerryarchibald.
* Fix multi-tab session lock on Firefox not being cleared ([\matrix-org#11800](matrix-org#11800)). Fixes element-hq/element-web#26165. Contributed by @ManuelHu.
* Deserialise spoilers back into slash command form ([\matrix-org#11805](matrix-org#11805)). Fixes element-hq/element-web#26344.
* Fix Incorrect message scaling for verification request ([\matrix-org#11793](matrix-org#11793)). Fixes element-hq/element-web#24304. Contributed by @capGoblin.
* Fix: Unable to restore a soft-logged-out session established via SSO ([\matrix-org#11794](matrix-org#11794)). Fixes element-hq/element-web#25957. Contributed by @kerryarchibald.
* Use configurable github issue links more consistently ([\matrix-org#11796](matrix-org#11796)).
* Fix io.element.late_event received_ts vs received_at ([\matrix-org#11789](matrix-org#11789)).
* Make invitation dialog scrollable when infos are too long ([\matrix-org#11753](matrix-org#11753)). Contributed by @nurjinjafar.
* Fix spoiler text-align ([\matrix-org#11790](matrix-org#11790)). Contributed by @ajbura.
* Fix: Right panel keeps showing chat when unmaximizing widget.  ([\matrix-org#11697](matrix-org#11697)). Fixes element-hq/element-web#26265. Contributed by @manancodes.
* Fix margin of invite to room button ([\matrix-org#11780](matrix-org#11780)). Fixes element-hq/element-web#26410.
* Update base64 import ([\matrix-org#11784](matrix-org#11784)).
* Set max size for Element logo in search warning ([\matrix-org#11779](matrix-org#11779)). Fixes element-hq/element-web#26408.
* Fix: emoji size in room header topic, remove obsolete emoji style ([\matrix-org#11757](matrix-org#11757)). Fixes element-hq/element-web#26326. Contributed by @kerryarchibald.
* Fix: Bubble layout design is broken ([\matrix-org#11763](matrix-org#11763)). Fixes element-hq/element-web#25818. Contributed by @manancodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Appearance A-E2EE-SAS-Verification A-Right-Panel good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Incorrect message scaling for verification request capGoblin/matrix-react-sdk
10 participants
@Johennes @t3chguy @luixxiul @SimonBrandner @eNkKVS4HxHc9jaq @KartikSingh023 @Inzamamdev @GH-aditya @varunlmxd and others