Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double chat (main + side) when un-maximising a widget with side chat #26265

Closed
Malix-Labs opened this issue Sep 29, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11697
Closed

Double chat (main + side) when un-maximising a widget with side chat #26265

Malix-Labs opened this issue Sep 29, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11697
Labels
A-Widgets O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Maximised-Widgets

Comments

@Malix-Labs
Copy link

Malix-Labs commented Sep 29, 2023 •
edited by weeman1337
Loading

Steps to reproduce

  • Create an empty room
  • Add a custom widget with e.g. https://example.com
  • Click the pin from the widget list in the right panel
  • Click maximise
  • Chat should now be on the right side, widget in the main area
  • Click un-maximise widget

Outcome

What did you expect?

image

What happened instead?

image

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@manancodes manancodes mentioned this issue Oct 2, 2023
Merged
3 tasks
@weeman1337
Copy link
Contributor

weeman1337 commented Oct 9, 2023 •
edited
Loading

Can reproduce. Updated repro steps in the issue description.

S-Minor because you can click the chat away as a workaround.

@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Widgets Z-Maximised-Widgets labels Oct 9, 2023
@weeman1337
Copy link
Contributor

Reopened because the fix was rolled back

@weeman1337 weeman1337 reopened this Oct 26, 2023
@HarHarLinks
Copy link
Contributor

potential dupe of #23591?

@t3chguy
Copy link
Member

t3chguy commented Nov 7, 2023

Duplicate of #23591

@t3chguy t3chguy marked this as a duplicate of #23591 Nov 7, 2023
@t3chguy t3chguy closed this as completed Nov 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
gabrc52 added a commit to sipb/matrix-react-sdk that referenced this issue Nov 12, 2023
@gabrc52
Merge tag 'v3.84.0' into sipb
5fb7725 
* Knock on a ask-to-join room if a module wants to join the room when navigating to a room ([\matrix-org#11787](matrix-org#11787)). Contributed by @dhenneke.
* Element-R:  Include crypto info in sentry ([\matrix-org#11798](matrix-org#11798)). Contributed by @florianduros.
* Element-R:  Include crypto info in rageshake ([\matrix-org#11797](matrix-org#11797)). Contributed by @florianduros.
* Element-R: Add current version of the rust-sdk and vodozemac ([\matrix-org#11785](matrix-org#11785)). Contributed by @florianduros.
* Fix unfederated invite dialog ([\matrix-org#9618](matrix-org#9618)). Fixes element-hq/element-meta#1466 and element-hq/element-web#22102. Contributed by @owi92.
* New right panel visual language ([\matrix-org#11664](matrix-org#11664)).
* OIDC: add friendly errors ([\matrix-org#11184](matrix-org#11184)). Fixes element-hq/element-web#25665. Contributed by @kerryarchibald.
* Fix rightpanel hiding scrollbar ([\matrix-org#11831](matrix-org#11831)). Contributed by @kerryarchibald.
* Fix multi-tab session lock on Firefox not being cleared ([\matrix-org#11800](matrix-org#11800)). Fixes element-hq/element-web#26165. Contributed by @ManuelHu.
* Deserialise spoilers back into slash command form ([\matrix-org#11805](matrix-org#11805)). Fixes element-hq/element-web#26344.
* Fix Incorrect message scaling for verification request ([\matrix-org#11793](matrix-org#11793)). Fixes element-hq/element-web#24304. Contributed by @capGoblin.
* Fix: Unable to restore a soft-logged-out session established via SSO ([\matrix-org#11794](matrix-org#11794)). Fixes element-hq/element-web#25957. Contributed by @kerryarchibald.
* Use configurable github issue links more consistently ([\matrix-org#11796](matrix-org#11796)).
* Fix io.element.late_event received_ts vs received_at ([\matrix-org#11789](matrix-org#11789)).
* Make invitation dialog scrollable when infos are too long ([\matrix-org#11753](matrix-org#11753)). Contributed by @nurjinjafar.
* Fix spoiler text-align ([\matrix-org#11790](matrix-org#11790)). Contributed by @ajbura.
* Fix: Right panel keeps showing chat when unmaximizing widget.  ([\matrix-org#11697](matrix-org#11697)). Fixes element-hq/element-web#26265. Contributed by @manancodes.
* Fix margin of invite to room button ([\matrix-org#11780](matrix-org#11780)). Fixes element-hq/element-web#26410.
* Update base64 import ([\matrix-org#11784](matrix-org#11784)).
* Set max size for Element logo in search warning ([\matrix-org#11779](matrix-org#11779)). Fixes element-hq/element-web#26408.
* Fix: emoji size in room header topic, remove obsolete emoji style ([\matrix-org#11757](matrix-org#11757)). Fixes element-hq/element-web#26326. Contributed by @kerryarchibald.
* Fix: Bubble layout design is broken ([\matrix-org#11763](matrix-org#11763)). Fixes element-hq/element-web#25818. Contributed by @manancodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Widgets O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Maximised-Widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Right panel keeps showing chat when unmaximizing widget. manancodes/matrix-react-sdk
4 participants
@t3chguy @HarHarLinks @weeman1337 @Malix-Labs