Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Cypress test: Read receipts > new messages > in threads > Sending a new different-thread message after marking as read makes it unread #26679

Closed
richvdh opened this issue Nov 30, 2023 · 5 comments · Fixed by matrix-org/matrix-react-sdk#11981 or matrix-org/matrix-react-sdk#12013
Closed

Flaky Cypress test: Read receipts > new messages > in threads > Sending a new different-thread message after marking as read makes it unread #26679

richvdh opened this issue Nov 30, 2023 · 5 comments · Fixed by matrix-org/matrix-react-sdk#11981 or matrix-org/matrix-react-sdk#12013
Labels
Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Nov 30, 2023

https://github.com/matrix-org/matrix-js-sdk/actions/runs/7036590881/job/19149559649#step:8:194

 1) Read receipts
       new messages
         in threads
           Sending a new different-thread message after marking as read makes it unread:

      Timed out retrying after 10000ms
      + expected - actual

      -'2'
      +'1'
      
      at Context.eval (webpack://matrix-react-sdk/./cypress/e2e/read-receipts/read-receipts-utils.ts:442:0)
@richvdh richvdh added the Z-Flaky-Test A test is raising false alarms label Nov 30, 2023
@richvdh richvdh mentioned this issue Nov 30, 2023
Merged
@richvdh
Copy link
Member Author

richvdh commented Nov 30, 2023

also https://github.com/matrix-org/matrix-js-sdk/actions/runs/7048396021/job/19184474380#step:8:194

@richvdh
Copy link
Member Author

richvdh commented Nov 30, 2023

For the record, this test was disabled until matrix-org/matrix-react-sdk#11903

richvdh added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 30, 2023
@richvdh
Attempt to deflake a read-receipts test
bf5938a 
Hopefully, this will fix element-hq/element-web#26679

(I think that the fourth message was arriving *after* the room was marked as
read, meaning that we ended up with two unread messages rather than one.)
@richvdh richvdh mentioned this issue Nov 30, 2023
Merged
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 1, 2023
@richvdh
Attempt to deflake a read-receipts test (#11981)
1f06d97 
* Attempt to deflake a read-receipts test

Hopefully, this will fix element-hq/element-web#26679

(I think that the fourth message was arriving *after* the room was marked as
read, meaning that we ended up with two unread messages rather than one.)

* Update cypress/e2e/read-receipts/new-messages.spec.ts

* prettier
@richvdh richvdh mentioned this issue Dec 4, 2023
Closed
@dbkr
Copy link
Member

dbkr commented Dec 4, 2023

Sadly this doesn't look like it's fixed the flake: it's still failed twice with this fix in https://github.com/matrix-org/matrix-react-sdk/actions/runs/7087197140 and https://github.com/matrix-org/matrix-react-sdk/actions/runs/7086785624 both of which were on b02ff16 which has the fix.

@dbkr dbkr reopened this Dec 4, 2023
@dbkr dbkr mentioned this issue Dec 4, 2023
Closed
3 tasks
@richvdh
Copy link
Member Author

richvdh commented Dec 4, 2023

links to the relevant failures:

https://github.com/matrix-org/matrix-react-sdk/actions/runs/7087197140/job/19286936806#step:8:189
https://github.com/matrix-org/matrix-react-sdk/actions/runs/7086785624/job/19285717668#step:8:188

both have failed with different errors to before:


  1) Read receipts
       new messages
         in threads
           Sending a new different-thread message after marking as read makes it unread:
     AssertionError: Timed out retrying after 10000ms: Expected <span.mx_NotificationBadge_count> not to exist in the DOM, but it was continuously found.
      at Context.eval (webpack://matrix-react-sdk/./cypress/e2e/read-receipts/read-receipts-utils.ts:418:0)

@florianduros florianduros mentioned this issue Dec 11, 2023
Merged
3 tasks
@florianduros
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#12013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
3 participants
@dbkr @richvdh @florianduros