Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completing @username mentions #6931

Closed
jcgruenhage opened this issue Jun 25, 2018 · 10 comments
Closed

Tab completing @username mentions #6931

jcgruenhage opened this issue Jun 25, 2018 · 10 comments

Comments

@jcgruenhage
Copy link

People are used to mention people with @username from all the other services (telegram, discord, gitter, slack), so the tab completion should probably try to ignore a leading "@" during completion.

@t3chguy
Copy link
Member

t3chguy commented Jun 25, 2018

the difficulty there is then what if I want to explicitly autocomplete by someone's MXID?

@jcgruenhage
Copy link
Author

Maybe try both and join the list of results?

@t3chguy
Copy link
Member

t3chguy commented Jun 25, 2018

That is what I presumed you were suggesting, but thats not

explicitly by someone's MXID

That's by MXID/Displayname

@jcgruenhage
Copy link
Author

Oh I see what you mean... Well what about selecting the mxid entry from that list then? That should work, right?

@t3chguy
Copy link
Member

t3chguy commented Jun 25, 2018

well I mean in the end they always get completed to a pill which has both MXID and Displayname (only the latter actually shown)
its just force of habit that I tend to autocomplete using people's MXIDs rather than their Displaynames

@jcgruenhage
Copy link
Author

well you could also build in a thing where for explicitly doing mxid's is \@localpar<tab> if you really need that

@t3chguy
Copy link
Member

t3chguy commented Jun 25, 2018

to be fair, for consistency with other autocompletes, @ should complete on both name and MXID, like room and community completers do

@turt2live
Copy link
Member

This sounds like a duplicate of #6782 (which is still a question?)

@jcgruenhage
Copy link
Author

@turt2live yes, it is a duplicate, I had not found that. Thanks!

@jcgruenhage
Copy link
Author

(Forgot to close this yesterday)

su-ex added a commit to SchildiChat/element-web that referenced this issue Oct 25, 2021
* Convert the "Cryptography" settings panel to an HTML table to assist screen reader users. ([\element-hq#6968](matrix-org/matrix-react-sdk#6968)). Contributed by [andybalaam](https://github.com/andybalaam).
* Swap order of private space creation and tweak copy ([\element-hq#6967](matrix-org/matrix-react-sdk#6967)). Fixes element-hq#18768 and element-hq#18768.
* Add spacing to Room settings - Notifications subsection ([\#6962](matrix-org/matrix-react-sdk#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema).
* Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\element-hq#6955](matrix-org/matrix-react-sdk#6955)). Contributed by [andybalaam](https://github.com/andybalaam).
* Fix space invite edge cases ([\element-hq#6884](matrix-org/matrix-react-sdk#6884)). Fixes element-hq#19010 element-hq#17345 and element-hq#19010.
* Allow options to cascade kicks/bans throughout spaces ([\element-hq#6829](matrix-org/matrix-react-sdk#6829)). Fixes element-hq#18969 and element-hq#18969.
* Make public space alias field mandatory again ([\element-hq#6921](matrix-org/matrix-react-sdk#6921)). Fixes element-hq#19003 and element-hq#19003.
* Add progress bar to restricted room upgrade dialog ([\element-hq#6919](matrix-org/matrix-react-sdk#6919)). Fixes element-hq#19146 and element-hq#19146.
* Add customisation point for visibility of invites and room creation ([\element-hq#6922](matrix-org/matrix-react-sdk#6922)). Fixes element-hq#19331 and element-hq#19331.
* Inhibit `Unable to get validated threepid` error during UIA ([\element-hq#6928](matrix-org/matrix-react-sdk#6928)). Fixes element-hq#18883 and element-hq#18883.
* Tweak room list skeleton UI height and behaviour ([\element-hq#6926](matrix-org/matrix-react-sdk#6926)). Fixes element-hq#18231 element-hq#16581 and element-hq#18231.
* If public room creation fails, retry without publishing it ([\#6872](matrix-org/matrix-react-sdk#6872)). Fixes element-hq#19194 and element-hq#19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr).
* Iterate invite your teammates to Space view ([\element-hq#6925](matrix-org/matrix-react-sdk#6925)). Fixes element-hq#18772 and element-hq#18772.
* Make placeholder more grey when no input ([\element-hq#6840](matrix-org/matrix-react-sdk#6840)). Fixes element-hq#17243 and element-hq#17243. Contributed by [wlach](https://github.com/wlach).
* Respect tombstones in locally known rooms for Space children ([\element-hq#6906](matrix-org/matrix-react-sdk#6906)). Fixes element-hq#19246 element-hq#19256 and element-hq#19246.
* Improve emoji shortcodes generated from annotations ([\element-hq#6907](matrix-org/matrix-react-sdk#6907)). Fixes element-hq#19304 and element-hq#19304.
* Hide kick & ban options in UserInfo when looking at own profile ([\element-hq#6911](matrix-org/matrix-react-sdk#6911)). Fixes element-hq#19066 and element-hq#19066.
* Add progress bar to Community to Space migration tool ([\element-hq#6887](matrix-org/matrix-react-sdk#6887)). Fixes element-hq#19216 and element-hq#19216.
* Fix leave space cancel button exploding ([\element-hq#6966](matrix-org/matrix-react-sdk#6966)).
* Fix edge case behaviour of the space join spinner for guests ([\element-hq#6972](matrix-org/matrix-react-sdk#6972)). Fixes element-hq#19359 and element-hq#19359.
* Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\element-hq#6965](matrix-org/matrix-react-sdk#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix text overflows button on Home page ([\#6898](matrix-org/matrix-react-sdk#6898)). Fixes element-hq#19180 and element-hq#19180. Contributed by [oliver-pham](https://github.com/oliver-pham).
* Space Room View should react to join rule changes down /sync ([\#6945](matrix-org/matrix-react-sdk#6945)). Fixes element-hq#19390 and element-hq#19390.
* Hide leave section button if user isn't in the room e.g peeking ([\element-hq#6920](matrix-org/matrix-react-sdk#6920)). Fixes element-hq#17410 and element-hq#17410.
* Fix bug where room list would get stuck showing no rooms ([\element-hq#6939](matrix-org/matrix-react-sdk#6939)). Fixes element-hq#19373 and element-hq#19373.
* Update room settings dialog title when room name changes ([\element-hq#6916](matrix-org/matrix-react-sdk#6916)). Fixes element-hq#17480 and element-hq#17480. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix editing losing emote-ness and rainbow-ness of messages ([\element-hq#6931](matrix-org/matrix-react-sdk#6931)). Fixes element-hq#19350 and element-hq#19350.
* Remove semicolon from notifications panel ([\element-hq#6930](matrix-org/matrix-react-sdk#6930)). Contributed by [robintown](https://github.com/robintown).
* Prevent profile image in left panel's backdrop from being selected ([\element-hq#6924](matrix-org/matrix-react-sdk#6924)). Contributed by [rom4nik](https://github.com/rom4nik).
* Validate that the phone number verification field is filled before allowing user to submit ([\element-hq#6918](matrix-org/matrix-react-sdk#6918)). Fixes element-hq#19316 and element-hq#19316. Contributed by [VFermat](https://github.com/VFermat).
* Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\element-hq#6917](matrix-org/matrix-react-sdk#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett).
* Use FocusLock around ContextMenus to simplify focus management ([\element-hq#6311](matrix-org/matrix-react-sdk#6311)). Fixes element-hq#19259 and element-hq#19259.
* Fix space hierarchy pagination ([\element-hq#6908](matrix-org/matrix-react-sdk#6908)). Fixes element-hq#19276 and element-hq#19276.
* Fix spaces keyboard shortcuts not working for last space ([\element-hq#6909](matrix-org/matrix-react-sdk#6909)). Fixes element-hq#19255 and element-hq#19255.
* Use fallback avatar only for DMs with 2 people. ([\element-hq#6895](matrix-org/matrix-react-sdk#6895)). Fixes element-hq#18747 and element-hq#18747. Contributed by [andybalaam](https://github.com/andybalaam).
williamkray added a commit to williamkray/element-web that referenced this issue Nov 9, 2021
* Convert the "Cryptography" settings panel to an HTML table to assist screen reader users. ([\element-hq#6968](matrix-org/matrix-react-sdk#6968)). Contributed by [andybalaam](https://github.com/andybalaam).
* Swap order of private space creation and tweak copy ([\element-hq#6967](matrix-org/matrix-react-sdk#6967)). Fixes element-hq#18768 and element-hq#18768.
* Add spacing to Room settings - Notifications subsection ([\#6962](matrix-org/matrix-react-sdk#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema).
* Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\element-hq#6955](matrix-org/matrix-react-sdk#6955)). Contributed by [andybalaam](https://github.com/andybalaam).
* Fix space invite edge cases ([\element-hq#6884](matrix-org/matrix-react-sdk#6884)). Fixes element-hq#19010 element-hq#17345 and element-hq#19010.
* Allow options to cascade kicks/bans throughout spaces ([\element-hq#6829](matrix-org/matrix-react-sdk#6829)). Fixes element-hq#18969 and element-hq#18969.
* Make public space alias field mandatory again ([\element-hq#6921](matrix-org/matrix-react-sdk#6921)). Fixes element-hq#19003 and element-hq#19003.
* Add progress bar to restricted room upgrade dialog ([\element-hq#6919](matrix-org/matrix-react-sdk#6919)). Fixes element-hq#19146 and element-hq#19146.
* Add customisation point for visibility of invites and room creation ([\element-hq#6922](matrix-org/matrix-react-sdk#6922)). Fixes element-hq#19331 and element-hq#19331.
* Inhibit `Unable to get validated threepid` error during UIA ([\element-hq#6928](matrix-org/matrix-react-sdk#6928)). Fixes element-hq#18883 and element-hq#18883.
* Tweak room list skeleton UI height and behaviour ([\element-hq#6926](matrix-org/matrix-react-sdk#6926)). Fixes element-hq#18231 element-hq#16581 and element-hq#18231.
* If public room creation fails, retry without publishing it ([\#6872](matrix-org/matrix-react-sdk#6872)). Fixes element-hq#19194 and element-hq#19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr).
* Iterate invite your teammates to Space view ([\element-hq#6925](matrix-org/matrix-react-sdk#6925)). Fixes element-hq#18772 and element-hq#18772.
* Make placeholder more grey when no input ([\element-hq#6840](matrix-org/matrix-react-sdk#6840)). Fixes element-hq#17243 and element-hq#17243. Contributed by [wlach](https://github.com/wlach).
* Respect tombstones in locally known rooms for Space children ([\element-hq#6906](matrix-org/matrix-react-sdk#6906)). Fixes element-hq#19246 element-hq#19256 and element-hq#19246.
* Improve emoji shortcodes generated from annotations ([\element-hq#6907](matrix-org/matrix-react-sdk#6907)). Fixes element-hq#19304 and element-hq#19304.
* Hide kick & ban options in UserInfo when looking at own profile ([\element-hq#6911](matrix-org/matrix-react-sdk#6911)). Fixes element-hq#19066 and element-hq#19066.
* Add progress bar to Community to Space migration tool ([\element-hq#6887](matrix-org/matrix-react-sdk#6887)). Fixes element-hq#19216 and element-hq#19216.
* Fix leave space cancel button exploding ([\element-hq#6966](matrix-org/matrix-react-sdk#6966)).
* Fix edge case behaviour of the space join spinner for guests ([\element-hq#6972](matrix-org/matrix-react-sdk#6972)). Fixes element-hq#19359 and element-hq#19359.
* Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\element-hq#6965](matrix-org/matrix-react-sdk#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix text overflows button on Home page ([\#6898](matrix-org/matrix-react-sdk#6898)). Fixes element-hq#19180 and element-hq#19180. Contributed by [oliver-pham](https://github.com/oliver-pham).
* Space Room View should react to join rule changes down /sync ([\#6945](matrix-org/matrix-react-sdk#6945)). Fixes element-hq#19390 and element-hq#19390.
* Hide leave section button if user isn't in the room e.g peeking ([\element-hq#6920](matrix-org/matrix-react-sdk#6920)). Fixes element-hq#17410 and element-hq#17410.
* Fix bug where room list would get stuck showing no rooms ([\element-hq#6939](matrix-org/matrix-react-sdk#6939)). Fixes element-hq#19373 and element-hq#19373.
* Update room settings dialog title when room name changes ([\element-hq#6916](matrix-org/matrix-react-sdk#6916)). Fixes element-hq#17480 and element-hq#17480. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix editing losing emote-ness and rainbow-ness of messages ([\element-hq#6931](matrix-org/matrix-react-sdk#6931)). Fixes element-hq#19350 and element-hq#19350.
* Remove semicolon from notifications panel ([\element-hq#6930](matrix-org/matrix-react-sdk#6930)). Contributed by [robintown](https://github.com/robintown).
* Prevent profile image in left panel's backdrop from being selected ([\element-hq#6924](matrix-org/matrix-react-sdk#6924)). Contributed by [rom4nik](https://github.com/rom4nik).
* Validate that the phone number verification field is filled before allowing user to submit ([\element-hq#6918](matrix-org/matrix-react-sdk#6918)). Fixes element-hq#19316 and element-hq#19316. Contributed by [VFermat](https://github.com/VFermat).
* Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\element-hq#6917](matrix-org/matrix-react-sdk#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett).
* Use FocusLock around ContextMenus to simplify focus management ([\element-hq#6311](matrix-org/matrix-react-sdk#6311)). Fixes element-hq#19259 and element-hq#19259.
* Fix space hierarchy pagination ([\element-hq#6908](matrix-org/matrix-react-sdk#6908)). Fixes element-hq#19276 and element-hq#19276.
* Fix spaces keyboard shortcuts not working for last space ([\element-hq#6909](matrix-org/matrix-react-sdk#6909)). Fixes element-hq#19255 and element-hq#19255.
* Use fallback avatar only for DMs with 2 people. ([\element-hq#6895](matrix-org/matrix-react-sdk#6895)). Fixes element-hq#18747 and element-hq#18747. Contributed by [andybalaam](https://github.com/andybalaam).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants